Comments (7)
Hey @davidchase, are you using rest.js's error interceptor? By default, rest.js considers any response to be successful, so the promises it returns will always fulfill, unless you ues the error interceptor to define that 404 (or whatever codes you want/need) should represent a failure.
If you verify that the promise is rejecting and flatMapError
still isn't kicking in, then we def need to dig deeper here. Let me know!
from most.
@briancavalier thanks for the quick reply
it seems like if i add rest.wrap(mime).wrap(errorCode);
I just get the one successful stream logging and the other logged message is Potentially unhandled rejection
but no 'hello'
from most.
Thanks @davidchase. Seems like it could be a bug. I'll look into it!
from most.
Ok, yep, it's a (braindead!) bug in fromPromise
. It isn't propagating an error when the promise rejects. I'll pull together a fix release asap, probably later tonight. Thanks for reporting this!
from most.
Thanks for looking into it
from most.
Ok, fix for fromPromise
(and unit test), is in master in c55c057. I still need to fix await
as well.
from most.
In master, both fromPromise
, and await
should correctly handle rejected promises. Please try them out, and let me know if you run into any other issues.
I'll plan to do a release over the weekend. I had more plans for 0.11.0, but this is important enough to warrant releasing 0.11.0 now (rather than 0.10.3, since there have been some significant changes since 0.10.2). We can include the other upcoming new things in 0.12.0.
Thanks again, @davidchase!
from most.
Related Issues (20)
- How to test delayed observables? HOT 1
- Debounce repeats last emission at completion HOT 9
- Proposal: Grammatical Typology to Enable Advanced Tooling HOT 3
- RemoveEventListener when using fromEvent HOT 3
- How to write a transducer? HOT 10
- Have you considered testing static pipelines as well in the perf tests? HOT 2
- awaitPromise() chain should have an timeout failure report option HOT 7
- Update the Perf Test readme
- Speed when using DOM compared to virtual DOM HOT 5
- Benchmark against Flyd HOT 3
- Just want to share most-koans I've built like 3 of years ago HOT 3
- fromPromise is not disposed correctly HOT 5
- Typescript: Bad function signature for .sample().
- Claiming support for "asynchronous generators" creates confusion
- adding Solid.js into the perf comparison HOT 2
- Clarify currently recommended version of Most
- good for dataflow graphs? HOT 1
- Wrong typescript type for $.ap() HOT 2
- Side-effect at end of stream HOT 1
- What happened to mostjs? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from most.