question about proportionalWidth/proportionalHeight sizing difference in horizontal layout about cuis-smalltalk-dev HOT 5 CLOSED

Or perhaps there could/should be an option for a row to be "vertically fitting" all the proportional elements according to their relative height proportions, just it is horizontally-fitting all the proportional elements according to the relative horizontal proportions. Is there such a way to do that? (so in the example 2 above, the orange bar would be 4 times as tall as the blue one).

from cuis-smalltalk-dev.

Davide, we could modify the behavior to be as you suggest. I even did it to play a bit with it (and haven't included the tweak in the update stream).
For minor direction layout (height in your example), the parameter (2.0 and 0.5 in your example) are taken as fractions of the available space. If a fraction greater than 1 is specified, it is considered 1. I think it is simple, and enough.
For major direction, I scaled everything by the sum of all fractions, but only if that sum is greater than one. This makes it easy to keep adding widgets without needing to tweak the fractions of all the previous ones. But it also allows exact control (by giving fractions that sum to less than 1).
Does this makes sense? Do you still see a reason for changing the minor (vertical) layout?

from cuis-smalltalk-dev.

Got it. I don't have a practical case. I'm going through the code and I was wondering if having only one unique way of calculating the proportions could be enough, it would seem simpler as opposed to having two, but maybe a matter of taste.

(which brings me to another question - the "adjustHorizontallyByAt" and "adjustVerticallyByAt" seem to be symmetrical methods that could be handled by one same function. Perhaps another case of having "one way of doing both things", perhaps would be simpler? )

from cuis-smalltalk-dev.

Well maybe those could be unified. If I remember correctly, when I wrote them I didn't find a trivial way to do it, without a significant performance penalty.

from cuis-smalltalk-dev.

Please email https://lists.cuis.st/mailman/listinfo/cuis-dev if you think this deserves further discussion.

from cuis-smalltalk-dev.