Code Monkey home page Code Monkey logo

Comments (6)

Cuevana avatar Cuevana commented on August 20, 2024

Good point. For now, we can ignore js and css directories.

from storm.

ivantodorovich avatar ivantodorovich commented on August 20, 2024

Made a PR to completely ignore Gulp generated files.

index.html and player.html will keep changing every time gulp generates files, because of the continious renaming of lib-.js and main-.css

I'm sorry I have to ask again, is this really necessary? I mean, cache should't be a problem here.. so what's the point?

from storm.

ivantodorovich avatar ivantodorovich commented on August 20, 2024

@Cuevana te pregunto.. cual es la finalidad de concatenar y revisionar los *.css y *.js?

En un webserver lo entiendo, pero un app de node-webkit no me cierra, sobre todo si el código es libre.

Tranquilamente podríamos injectar los assets originales, sería mucho más facil de debuggear. No te parece?

Además, como beneficio extra, index.html y player.html dejarían de ser modificados con cada cambio, git estaría tranquilo con eso y el repositorio estaría siempre en un estado listo para ser ejecutado, sin la necesidad de gulp (sólo haría falta para developers)

Me estoy perdiendo de algo?

from storm.

cesasol avatar cesasol commented on August 20, 2024

Bueno, git está hecho para devolpers y testers

from storm.

Cuevana avatar Cuevana commented on August 20, 2024

Estamos removiendo gulp, comentando algunas secciones, además de añadiendo localización. Haremos un push en algunos minutos.

from storm.

ivantodorovich avatar ivantodorovich commented on August 20, 2024

Ok @Cuevana, genial! Lo veré mañana porque me estoy yendo 👍

@cesasol For the record.. mi sugerencia no era remover gulp completamente, sólo las tareas de concatenación y de revisión, ya que son las que molestan a la hora de debuggear. No tengo nada en contra de gulp, de hecho me parece muy útil, en este caso para compilar less y la inyección de html

from storm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.