Code Monkey home page Code Monkey logo

Comments (1)

gaeljw avatar gaeljw commented on June 17, 2024 1

Also considering that DataTable can contain null values but null is not expected in Scala, we should probably filter out the null values.

In the example of a table read as List[Map[K,V]] this would lead to inconsistent maps for each row: not all the maps would have the same keys.

In the example of a table read as List[List[V]] the issue is even more visible: each row could be represented with a list of a different size.
If people are reading the rows using the index like row(2), this would mess things up as the index would not necessarily match the column number of the table.

▶️ This means we should not filter null values.


The correct Scala way would be to wrap cell values as Options.

For instance table.asScalaMaps[String,String] would actually return a Seq[Map[String, Option[String]]] rather than a Seq[Map[String, String]].
And we would convert null values to None.

Users would then use the table like this:

table.asScalaMaps[String,String] // Seq[Map[String, Option[String]]]
  .map { row =>
    val name = row("name").getOrElse("")
    // Or a bit uglier if you are not sure the key is always defined
    val surname = row.get("surname").flatten.getOrElse("")
  }

I'll give a look to existing codebases using Cucumber Scala but I believe this solution has no much drawback

from cucumber-jvm-scala.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.