Code Monkey home page Code Monkey logo

Comments (10)

cubiq avatar cubiq commented on May 18, 2024

I noticed this... and I don't really know how to fix it. The message should point down with HW button and up otherwise, so changing the icon to "menu" wouldn't suffice. I could try to spoof the devices with HW button from the user agent, but that would be a hell to maintain.

I'm open to other ideas.

from add-to-homescreen.

danbrady avatar danbrady commented on May 18, 2024

Yeah, I hear you. I don't think you'd want to rely on the UA .

Another idea, although not very elegant, is to show both button image types in the message (providing that the hardware button icon is always relatively similar?). For example, "...tap [three dots] or [menu page thingy] and then add to homescreen". At that point, it would probably be better to lose the arrow completely and just center the message on the display.

from add-to-homescreen.

twhitbeck avatar twhitbeck commented on May 18, 2024

Another unfortunate aspect of this is that the hardware "menu" button looks different on different Android devices.
android hardware buttons
more android hardware buttons
However, according to this Smashing Magazine article, Google is removing the hardware menu button from newer devices.

from add-to-homescreen.

cubiq avatar cubiq commented on May 18, 2024

Nexus 5 has no HW button, but samsung market is pretty big. I believe the only solution is to place the message in the center of the screen and say something like "press the menu button"

from add-to-homescreen.

leoherzog avatar leoherzog commented on May 18, 2024

It is definitely against Android's design guidelines to use a Menu button. A couple of years ago, Google removed the menu button and replaced it with the action bar, and any devices that have a menu button are going against Android proper. It is a safe bet that any device with Android 2.3 or older will have one, and any device with 4.0 or new should not have one.

http://developer.android.com/design/patterns/actionbar.html

from add-to-homescreen.

twhitbeck avatar twhitbeck commented on May 18, 2024

@cubiq Agreed, it seems like the best option is just a generally centered modal with less specific instructions. Tap the menu button and choose "Save to homescreen"

from add-to-homescreen.

cubiq avatar cubiq commented on May 18, 2024

maybe then "press the menu button or tap the menu icon and blah blah"

from add-to-homescreen.

twhitbeck avatar twhitbeck commented on May 18, 2024

In light of this, do you plan to make the proposed change? Rather than pointing to the menu button, just have a modal.

from add-to-homescreen.

cubiq avatar cubiq commented on May 18, 2024

Yes that is the intention

from add-to-homescreen.

cubiq avatar cubiq commented on May 18, 2024

latest release tries to fix this. thoughts?

from add-to-homescreen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.