Comments (10)
I noticed this... and I don't really know how to fix it. The message should point down with HW button and up otherwise, so changing the icon to "menu" wouldn't suffice. I could try to spoof the devices with HW button from the user agent, but that would be a hell to maintain.
I'm open to other ideas.
from add-to-homescreen.
Yeah, I hear you. I don't think you'd want to rely on the UA .
Another idea, although not very elegant, is to show both button image types in the message (providing that the hardware button icon is always relatively similar?). For example, "...tap [three dots] or [menu page thingy] and then add to homescreen". At that point, it would probably be better to lose the arrow completely and just center the message on the display.
from add-to-homescreen.
Another unfortunate aspect of this is that the hardware "menu" button looks different on different Android devices.
However, according to this Smashing Magazine article, Google is removing the hardware menu button from newer devices.
from add-to-homescreen.
Nexus 5 has no HW button, but samsung market is pretty big. I believe the only solution is to place the message in the center of the screen and say something like "press the menu button"
from add-to-homescreen.
It is definitely against Android's design guidelines to use a Menu button. A couple of years ago, Google removed the menu button and replaced it with the action bar, and any devices that have a menu button are going against Android proper. It is a safe bet that any device with Android 2.3 or older will have one, and any device with 4.0 or new should not have one.
http://developer.android.com/design/patterns/actionbar.html
from add-to-homescreen.
@cubiq Agreed, it seems like the best option is just a generally centered modal with less specific instructions. Tap the menu button and choose "Save to homescreen"
from add-to-homescreen.
maybe then "press the menu button or tap the menu icon and blah blah"
from add-to-homescreen.
In light of this, do you plan to make the proposed change? Rather than pointing to the menu button, just have a modal.
from add-to-homescreen.
Yes that is the intention
from add-to-homescreen.
latest release tries to fix this. thoughts?
from add-to-homescreen.
Related Issues (20)
- Error when force show on desktop HOT 1
- Request for .remove() function
- request for .onError() setting
- Steps are confusing to some testers
- It don't work with chrome navigator
- Images in css not showing HOT 5
- how to track entrances
- ios 11 support? HOT 4
- Wordpress plugin Update.
- iOS 11 fix HOT 1
- Lo-res image used HOT 7
- Support CP 47 subtag that are not defined
- Images won't appear in Safari browser HOT 6
- Bubble does not appear in correct location on landscape iPhone HOT 1
- required support HOT 1
- Website does not load
- Hide banner on Android
- Uncaught TypeError: Cannot read property 'appendChild' of null (addtohomescreen.js:553) HOT 1
- iOS 12 support? HOT 1
- Looking for documentation? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from add-to-homescreen.