Code Monkey home page Code Monkey logo

Comments (7)

il-s avatar il-s commented on May 18, 2024

Solution path:

add in src/js/libs/utils/utils.js

export function initModals() {
  let targets = document.querySelectorAll(".modal-trigger");
  if (typeof targets != "undefined" && targets != null) {
    for (var i = 0, len = targets.length; i < len; i++) {
        targets[i].addEventListener('click',  function (event) {
          console.log('click modal');
          var modalID = this.getAttribute('data-modal');
          document.querySelector('#' + modalID).classList.add('is-active');
        })
    }
  }

  targets = document.querySelectorAll(".modal-close");
  if (typeof targets != "undefined" && targets != null) {
    for (var i = 0, len = targets.length; i < len; i++) {
        targets[i].addEventListener('click',  function (event) {
          console.log('click modal close');
          this.closest('.modal').classList.remove('is-active');
        })
    }
  }
}

in js/main.js

  1. add initModals in import from ulils.js
  2. add in document.onreadystatechange = function () {
...
const modals = initModals();

Enjoy)

from fresh.

 avatar commented on May 18, 2024

Hi, thanks for this contribution. Would you be kind to submit it as a PR? I'll review it and merge it then. Thanks!

from fresh.

il-s avatar il-s commented on May 18, 2024

There are still problems there:

  1. navbar will overlap the close button
  2. in modal mode, the backtotop button is again visible and active
  3. scrolling continues when the modal is open

I do not yet have a solution to these questions, but I continue to think about it.

from fresh.

 avatar commented on May 18, 2024

You can submit the PR as is and I can fix the remaining points you shared.

from fresh.

il-s avatar il-s commented on May 18, 2024

Add PR #26

from fresh.

 avatar commented on May 18, 2024

Thanks for your PR. I also made some changes to include what you've asked for. Please test and close the issue if you're ok with it.

from fresh.

il-s avatar il-s commented on May 18, 2024

Thank you very much! Everything works as it should.

from fresh.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.