set_value argument name: src or values about bmi-python HOT 5 CLOSED

@visr This is great! @ethan-pierce is also working with BMI for Julia. I believe his repository is private at the moment but you two should compare notes sometime.

from bmi-python.

@visr It should be src, to match bmi.sidl. Thanks for spotting this error!

from bmi-python.

Fixed with 17d7d72.

from bmi-python.

Ok thanks! I assumed it should be src. What I meant was that 17d7d72 breaks code of people that used keyword agument syntax like set_value(name="myname", values=np.zeros(3)) as opposed to set_value("myname", np.zeros(3)), since values is now not an argument name anymore. Not sure if that is an issue in practice though, you can probably judge that better.

For your information, the main reason I was carefully reading it was because I used it as a basis for https://github.com/Deltares/BasicModelInterface.jl. Not sure to which extent you would be interested in a Julia BMI specification next to the C, C++, Fortran and Python ones. As I mention in the readme it probably still needs some implementations to prove itself. But perhaps it's good you are aware of its existence. If you'd want to adopt it eventually I'd be happy to transfer the repo to the CSDMS org.

from bmi-python.

Great, thanks for letting me know. @ethan-pierce, feel free to create an issue on the BasicModelInterface.jl repository to discuss anything, or if you prefer you can drop me an email as well. I didn't register BasicModelInterface.jl as a package yet, so we could also go with what you worked on.

from bmi-python.