Code Monkey home page Code Monkey logo

Comments (10)

zanami avatar zanami commented on May 24, 2024 2

This might be useful JedWatson/react-select#4804 (comment)

from chakra-react-select.

csandman avatar csandman commented on May 24, 2024 2

I know it took a while but i finally updated to react-select@5! It involved some major structural changes to the code, but the result is that the types are finally implemented correctly. Please give 3.0.0 a try when you can and leave a new issue if something broke!

Also thanks to @zanami for the link about module augmentation, that ended up being one of the most important strategies I had to use to make this wrapper work correctly.

from chakra-react-select.

csandman avatar csandman commented on May 24, 2024 1

@sshyam-gupta be my guest! To give it a shot, you can just upgrade react-select to latest, and remove @types/react-select and see about replacing it. I think one of the main things I don't have set up properly is the generics. If you have any questions let me know!

from chakra-react-select.

csandman avatar csandman commented on May 24, 2024

Wow, what timing haha. I'll get a new version pushed up ASAP!

from chakra-react-select.

csandman avatar csandman commented on May 24, 2024

Just installed to see what happens, and a lot of my types are broken haha. Unfortunately I'm very new to typescript so it will probably take me a while to figure out how to fix everything, but if anyone wants to give it a shot in the mean time, feel free!

@bbovenzi @ejoc

from chakra-react-select.

sshyam-gupta avatar sshyam-gupta commented on May 24, 2024

@csandman can I try and help here?

from chakra-react-select.

sshyam-gupta avatar sshyam-gupta commented on May 24, 2024

@csandman How do I validate this? any contribution doc?

from chakra-react-select.

csandman avatar csandman commented on May 24, 2024

I am working on a contribution doc, but I'm still figuring it out.

By "validate" do you mean test it to make sure it works? Or that it passes all lint rules? Because I have pre-commit hooks set up to ensure it passes all lint rules before anything gets pushed.

from chakra-react-select.

sshyam-gupta avatar sshyam-gupta commented on May 24, 2024

yes @csandman , I made changes and want to test if it works. Is there any script available or I need to npm link to package?

from chakra-react-select.

csandman avatar csandman commented on May 24, 2024

There in nothing in the main branch set up for testing right now, there is a storybook branch in progress but it's not ready to merge into main yet, however it is functional so you could try your changes against that if you'd like. Otherwise an npm link is probably your best bet.

from chakra-react-select.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.