Instruction.semantics should be renamed about pyevmasm HOT 5 CLOSED

From a quick look on definitions...
mnemonics: a system such as a pattern of letters, ideas, or associations which assists in remembering something.
semantics: the meaning and interpretation of words, signs, and sentence

What would be the mnemonic for "PUSH32". ? PUSH?

from pyevmasm.

from pyevmasm.

https://github.com/trailofbits/pyevmasm/blob/master/pyevmasm/evmasm.py#L337

from pyevmasm.

So there is already a .mnemonic that does what you want.

    @property
    def mnemonic(self):
        """ Alias for name """
        return self.name

Should we close this or do you have a proposal for renaming semantics to something else?

Note it should capture the basic semantic meaning of the instructions (mostly for the ones that have several sizes but do the same thing) SWAP, PUSH, LOG

from pyevmasm.

So there is already a .mnemonic that does what you want.
ah I see. Sorry, I should have looked more carefully then :( closing!

from pyevmasm.