Comments (7)
@vclayton thanks for the interest on this issue! And also for taking the time to read the game design document :)
Calling enemy.take_damage
from the missile scene is fine 👌
Regarding the multiple types of projectiles I would simply set a missile.damage
property from the Tower.fire
method.
Are all projectiles of the same type?
Currently yes. The only thing that changes is the damage dealt to the enemies.
It would be nice to change missile texture and stats based on the turret that fired it, but this can be done in a separate issue since it's important to have the take_damage
implemented ASAP. However it was a good question, so we can keep this in mind.
Regarding the implementation I think it would be better to keep the Missile independent from the Tower.
This can be done by creating a Missile resource, like we already done for Enemies and Towers.
from hacktoberfest-2020.
I'm working on the money drop though. 😅
from hacktoberfest-2020.
I'd love to at least get this started. I've read through the Game Design Doc about the different tower types and enemy armor. Looking at the Ammo class I see the code for exploding when hitting an enemy, so that's where I'd start. Probably by calling a take_damage
function on the enemy the projectile collides with. Or each enemy within the splash area, for missiles.
That brings up a question though: Are all projectiles of the same type? There's just the missile at the moment. The design makes it sound like the projectile's damage characteristics are determined by what tower fired it, so I think the projectile needs a reference back to its tower to get that info at collision time. Either that or the towers need to all fire different types of projectiles, but I think having a reference back is simpler.
from hacktoberfest-2020.
@vclayton Hey sorry to bother you but do you have an ETA for this pull request? Since tomorrow is the last day of the Hacktoberfest, I would like to get this integrated in the main gameplay. If you don't have time to finish this tomorrow, I understand and I can take it. Sorry for bothering you.
PS: if you want to join the development I'll be live streaming on Twitch tomorrow on https://www.twitch.tv/crystal_bit
from hacktoberfest-2020.
Oh no! I've posted 3 pull requests for this, but didn't see the issue here though I've searched for it. I'm sorry. 😶
from hacktoberfest-2020.
Thanks @FlavioFS for the help!
Also thanks @vclayton and sorry for the rushed management of this issue 🙏
from hacktoberfest-2020.
No problem. I got distracted by some chores around the house. I'm glad to see it working. 👍
from hacktoberfest-2020.
Related Issues (20)
- Towers don't fire sometimes HOT 1
- Update pause layer style and fonts HOT 2
- Reopen strategic point menu HOT 2
- "Once a rock spoke to me"
- Remove unused assets
- Replace the current call enemies button with "EnemyCallButton" scene HOT 1
- Fix z-order of enemy HP bars HOT 2
- Handle the enemy deletion (queue_free) when enemies reach player base
- Add background music to main menu HOT 1
- Should we rename Ammo to Projectile? HOT 1
- Balance enemies, waves, turrets stats (speed, hp, attack rate,...)
- Fix turret and missile rotation HOT 1
- Refactoring enemy queue_free()
- Create Game over overlay HOT 1
- Create victory screen
- Create victory overlay
- Create title image for main menu HOT 3
- Fix projectile spawn position - Do not overlap with turret sprite
- Create explosion scene for projectile-enemy collision HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hacktoberfest-2020.