Light

Calling get() multiple times in a row fails on certain Android devices. about cordova-plugin-secure-storage HOT 7 CLOSED

crypho commented on July 26, 2024

Calling get() multiple times in a row fails on certain Android devices.

from cordova-plugin-secure-storage.

Comments (7)

demetris-manikas commented on July 26, 2024

Unfortunately I cannot reproduce the error on my Galaxy S5 running android 6.0.1.
Maybe you have to get rid of your S6 and get the S7 (oxoxo).

from cordova-plugin-secure-storage.

ggozad commented on July 26, 2024

From adb logcat

11-17 14:28:39.197 14795 15211 E SecureStorage: Decrypt (RSA/AES) failed :
11-17 14:28:39.197 14795 15211 E SecureStorage: javax.crypto.IllegalBlockSizeException
11-17 14:28:39.197 14795 15211 E SecureStorage:     at android.security.keystore.AndroidKeyStoreCipherSpiBase.engineDoFinal(AndroidKeyStoreCipherSpiBase.java:486)
11-17 14:28:39.197 14795 15211 E SecureStorage:     at javax.crypto.Cipher.doFinal(Cipher.java:1502)
11-17 14:28:39.197 14795 15211 E SecureStorage:     at com.crypho.plugins.RSA.decrypt(RSA.java:28)
11-17 14:28:39.197 14795 15211 E SecureStorage:     at com.crypho.plugins.SecureStorage$3.run(SecureStorage.java:126)
11-17 14:28:39.197 14795 15211 E SecureStorage:     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
11-17 14:28:39.197 14795 15211 E SecureStorage:     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
11-17 14:28:39.197 14795 15211 E SecureStorage:     at java.lang.Thread.run(Thread.java:818)
11-17 14:28:39.197 14795 15211 E SecureStorage: Caused by: android.security.KeyStoreException: Invalid operation handle
11-17 14:28:39.197 14795 15211 E SecureStorage:     at android.security.KeyStore.getKeyStoreException(KeyStore.java:944)
11-17 14:28:39.197 14795 15211 E SecureStorage:     at android.security.keystore.KeyStoreCryptoOperationChunkedStreamer.doFinal(KeyStoreCryptoOperationChunkedStreamer.java:224)
11-17 14:28:39.197 14795 15211 E SecureStorage:     at android.security.keystore.AndroidKeyStoreCipherSpiBase.engineDoFinal(AndroidKeyStoreCipherSpiBase.java:473)

from cordova-plugin-secure-storage.

demetris-manikas commented on July 26, 2024

#20 looks like a similar error.

from cordova-plugin-secure-storage.

ggozad commented on July 26, 2024

Fixed in #76, preferably it should have been done within the native part, but java...

from cordova-plugin-secure-storage.

demetris-manikas commented on July 26, 2024

#76 doesn't make sense to me, I believe it just hides another problem or bug.
Why fix only get and not set?
There is no reason why only one thread can decrypt but many can encrypt.
And for god sake java is not the problem here.
The code should be asynchromous and it was written this way on purpose.
If you wish to turn the android code to synchronous just remove threading from SecureStorage.java.
Has anyone reported problems on phones different from Samsung 6?

from cordova-plugin-secure-storage.

ggozad commented on July 26, 2024

This is indeed the case, hence the note that this should be fixed in the android part.
The problem manifests only during decryption, which is why we only throttle then.
The problem appears in many different phones. I personally checked with S7 and a few others all running 6.0.1, it appears in most of them.
I will be happy to remove the queue, but it is obvious that this will happen only when the native part works as expected.

from cordova-plugin-secure-storage.

demetris-manikas commented on July 26, 2024

Then it is much simpler to just add the synchronized keyword to the declarations of the encrypt, decrypt methods of the RSA.java and AES.java.

from cordova-plugin-secure-storage.

Related Issues (20)

Where can I inspect the saved passwords on my iOS device? HOT 4
Exception on Android Pie HOT 7
Where is sjcl_ss.js? HOT 4
Dependency on SAMKeychain HOT 3
uncaught exception error HOT 3
Do not rely on internal Android API for screen unlock HOT 11
Usage of OAEP HOT 1
Link doesn't work in readme HOT 1
Exception on Android Pie after adding back lock screen HOT 15
Save value of ss.get() in a variable ? HOT 1
Android Q API 28 ERROR: No Activity found to handle Intent { act=com.android.credentials.UNLOCK } HOT 32
iOS User interaction is not allowed HOT 1
Data is still accessible after loging out of icloud HOT 1
icloud
App using unlockCredentials crash on Android Q HOT 2
Refactor actions in static class so it can be re-used by other plugins HOT 1
How to check whether key exist or not HOT 1
android.content.ActivityNotFoundException HOT 2
Capacitor support HOT 1
Still having a problem with this. Running emulator on 12.1

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.