Code Monkey home page Code Monkey logo

Comments (9)

ggozad avatar ggozad commented on August 30, 2024

I would love it if you turned this into a proper pull request. That would mean document the options possible and how to set them and tests. Do not worry about reviewing ahead of the PR, we can take it as we go. Note that atm I am stumped with all sorts of things so I will take some time.

from cordova-plugin-secure-storage.

spaceagegroop avatar spaceagegroop commented on August 30, 2024

@ggozad thanks for the feedback, I will do my best. This is my first time actually contributing on a project on GitHub. Thanks for all your work on this plugin!

from cordova-plugin-secure-storage.

ggozad avatar ggozad commented on August 30, 2024

Welcome to the open-source club 👍 I hope you will find it as gratifying as I have :)

from cordova-plugin-secure-storage.

ggozad avatar ggozad commented on August 30, 2024

Any news on this? I am reluctant to close it as I would like to have a proper PR.

from cordova-plugin-secure-storage.

dcousens avatar dcousens commented on August 30, 2024

Does this imply iCloud backups are on by default right now?

from cordova-plugin-secure-storage.

ggozad avatar ggozad commented on August 30, 2024

@dcousens it does.

from cordova-plugin-secure-storage.

dcousens avatar dcousens commented on August 30, 2024

@ggozad out of interest, what does an iCloud backup even mean if it a DeviceOnly attribute is given?

from cordova-plugin-secure-storage.

ggozad avatar ggozad commented on August 30, 2024

@dcousens my guess is that then no backup is taking place.
In any case this is a great candidate for an easy pull request where a config option is added to set the desired behavior.

from cordova-plugin-secure-storage.

demetris-manikas avatar demetris-manikas commented on August 30, 2024

KeychainAccessibility is the config option. Values not ending in ThisDeviceOnly provide iCloud storage only when encrypted backups are in use.
We might need to mention this in the readme.
Anyway I believe this thread should close.

from cordova-plugin-secure-storage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.