Code Monkey home page Code Monkey logo

Comments (5)

ggozad avatar ggozad commented on August 30, 2024

Would appreciate some more feedback on this, perhaps a PR?

from cordova-plugin-secure-storage.

ggozad avatar ggozad commented on August 30, 2024

I released a new version and added some more tests to cover this. It works fine here, the error callback should always be called, please test and let me know if it still fails for you.

from cordova-plugin-secure-storage.

szh avatar szh commented on August 30, 2024

Thanks for the quick response. I went ahead and ran the tests, and they do pass. Unfortunately it's very hard to reproduce this error. It usually happens when I launch the app, in case that helps.
I actually have code in my error handler to try to catch the error but it seems to either skip it or maybe it throws the error even after the handler is called:

this.ss.get((val) => resolve(val), (e) => {
  if (String(e).includes("errSecItemNotFound")) {
    resolve(null); // Item not found in Keychain
  } else {
    reject(e);
  }
}, key);

from cordova-plugin-secure-storage.

ggozad avatar ggozad commented on August 30, 2024

I am guessing you do wait for deviceready before everything?

With regards to the snippet: SecureStorage.get will reject if it does not find a value. You can of course catch that and return null instead, but does it ever return null when there is no such item?

from cordova-plugin-secure-storage.

szh avatar szh commented on August 30, 2024

Yes, I'm waiting for deviceready.
You're right, it doesn't return null. I thought it was, b/c I was handling that in code elsewhere in my app.
I guess there's really no way to fix this if we can't reproduce it. I'll report back if I have more details that could help.

from cordova-plugin-secure-storage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.