Code Monkey home page Code Monkey logo

Comments (6)

ggozad avatar ggozad commented on July 26, 2024 1

Ouch!
That's pretty bad, will try to fix this week. Would it be possible to make a failing test case for the above?

from cordova-plugin-secure-storage.

Alex-Sessler avatar Alex-Sessler commented on July 26, 2024 1

I tested the branch version and it seems to fix my issues... Awesome, thanks!

from cordova-plugin-secure-storage.

Alex-Sessler avatar Alex-Sessler commented on July 26, 2024

Hm, what do you mean with "a failing test case"? In my first example, the get call fails and in the second example the set call succeeds. Since all functions use the same helper functions on error/succeed I though that should be good enough.

from cordova-plugin-secure-storage.

ggozad avatar ggozad commented on July 26, 2024

I mean there is a small test suite in the package. If you could write a test case that fails (copy pasting the above and asserting that all callbacks are called properly) that would save me some trouble :)

from cordova-plugin-secure-storage.

ggozad avatar ggozad commented on July 26, 2024

I've added a branch with a test case that demonstrates this in FIX-thread-callbacks.
Seems that since callbackId is kept in self, this is overwritten every time.
@goshakkk would you please be able to fix this?

from cordova-plugin-secure-storage.

ggozad avatar ggozad commented on July 26, 2024

Seems I have fixed this in FIX-thread-callbacks. Tests now all pass including multiple calls to securestorage.
@Alex-Sessler could you please verify with your app running the branch?

from cordova-plugin-secure-storage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.