Comments (6)
Ouch!
That's pretty bad, will try to fix this week. Would it be possible to make a failing test case for the above?
from cordova-plugin-secure-storage.
I tested the branch version and it seems to fix my issues... Awesome, thanks!
from cordova-plugin-secure-storage.
Hm, what do you mean with "a failing test case"? In my first example, the get call fails and in the second example the set call succeeds. Since all functions use the same helper functions on error/succeed I though that should be good enough.
from cordova-plugin-secure-storage.
I mean there is a small test suite in the package. If you could write a test case that fails (copy pasting the above and asserting that all callbacks are called properly) that would save me some trouble :)
from cordova-plugin-secure-storage.
I've added a branch with a test case that demonstrates this in FIX-thread-callbacks.
Seems that since callbackId is kept in self, this is overwritten every time.
@goshakkk would you please be able to fix this?
from cordova-plugin-secure-storage.
Seems I have fixed this in FIX-thread-callbacks. Tests now all pass including multiple calls to securestorage.
@Alex-Sessler could you please verify with your app running the branch?
from cordova-plugin-secure-storage.
Related Issues (20)
- Where can I inspect the saved passwords on my iOS device? HOT 4
- Exception on Android Pie HOT 7
- Where is sjcl_ss.js? HOT 4
- Dependency on SAMKeychain HOT 3
- uncaught exception error HOT 3
- Do not rely on internal Android API for screen unlock HOT 11
- Usage of OAEP HOT 1
- Link doesn't work in readme HOT 1
- Exception on Android Pie after adding back lock screen HOT 15
- Save value of ss.get() in a variable ? HOT 1
- Android Q API 28 ERROR: No Activity found to handle Intent { act=com.android.credentials.UNLOCK } HOT 32
- iOS User interaction is not allowed HOT 1
- Data is still accessible after loging out of icloud HOT 1
- icloud
- App using unlockCredentials crash on Android Q HOT 2
- Refactor actions in static class so it can be re-used by other plugins HOT 1
- How to check whether key exist or not HOT 1
- android.content.ActivityNotFoundException HOT 2
- Capacitor support HOT 1
- Still having a problem with this. Running emulator on 12.1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cordova-plugin-secure-storage.