Doesn't handle filenames with spaces in about mp3binder HOT 7 CLOSED

Hello @pcolmer,

thanks for bringing this up. I'll look into it.

from mp3binder.

I believe xargs messes thing up. I'm using this simple bash script to see what xargs provides:

i=1;
for arg in "$@"
do
    echo "Arg - $i: $arg";
    i=$((i + 1));
done

Calling xargs the way you provided results in:

FILELIST=$(xargs -d "\n" -a list.txt ls --quoting-style=c); ./foo.sh $FILELIST
Arg - 1: "
Arg - 2: sample2.mp3"
Arg - 3: "sample
Arg - 4: 1.mp3"
Arg - 5: "sample.
Arg - 6: 4.mp3"
Arg - 7: "silence
Arg - 8: copy.mp3"

Are you interested in an --input option where you could provide the file directly?

from mp3binder.

Are you interested in an --input option where you could provide the file directly?

Yes, please :)

Thank you for taking the time to investigate xargs and its behaviour.

If you are able to add an --input option, that would be much appreciated!

from mp3binder.

Hello @pcolmer,

please check the latest pre-release and use the option --input. There is no need to quote each line, but keep in mind that leading and tailing white spaces will be respected.

from mp3binder.

Hello @crra

Thank you for making this addition.

There is something about the created output file that Windows Media Player doesn't like, unfortunately. I can play it with VLC though.

Using mpck (https://github.com/Sjord/checkmate) on the built file, it reports the following:

SUMMARY: foo.mp3
    version                       MPEG v1.0
    layer                         3
    average bitrate               -21743 bps (VBR)
    samplerate                    44100 Hz
    frames                        2020051
    time                          -743:-42.-869
    unidentified                  886 b (0%)
    errors                        unidentified bytes
                                  inconsistent frame headers
                                  invalid header values
    result                        Bad

If I use the same tool on the (397) source files, they are all reported OK.

I hope that helps. Please let me know if you need me to run anything else over the files.

from mp3binder.

Do you have a file to share to analyze?

from mp3binder.

@pcolmer I've moved the problem with the corrupt output file to a new issue (#23) so that we can close this one (different scope).

from mp3binder.