Comments (3)
note that while all DB classes already have a marshal
function (and this function is indeed used in eg the xbrnetwork backend or the market maker), this is not covered by tests, and eg inconsistent types had been a practical headache already
also note, the User.parse
class function, which is lacking from most of the other DB classes, but should be there, because it is the "inverse" of marshal
from cfxdb.
So it seems all our current tests are centered around the fbs variants of things (apart from the tests you linked above) because our database schema classes are from flatbuffers. We'd first need to write schema classes that are cbor-able.
@oberstet do we need to do that now ?
from cfxdb.
do we need to do that now ?
all our DB classes need to have "marshal" and "parse", so yes, adding those is part A of this issue. part B is then adding the tests using the new functions (and the existings fbs ones) ..
from cfxdb.
Related Issues (20)
- Refactor DB classes into modules HOT 2
- Travis CI reports “Expected - Waiting for status to be reported” HOT 6
- Refactor tests to individual file
- DB schema: fix actor types
- tid + signature for all on-chain object tables HOT 1
- Add slots to DB table classes HOT 4
- Database schema classes HOT 1
- Split up XBR DB HOT 2
- Document standard DB types HOT 1
- Complete cluster DB schema HOT 1
- Expand master DB schema HOT 2
- Migrate master tables to flatbuffers
- Add UserRole.SUPERUSER
- close_balance in a channel should return uint256 HOT 3
- Add schema tables parse function
- Complete XBR API schema
- CI: datetime roundtrip tests 1h off HOT 1
- autoapi linking broken for RTD
- Depend on argon2-cffi, not argon2 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cfxdb.