Code Monkey home page Code Monkey logo

Comments (10)

crisbeto avatar crisbeto commented on June 10, 2024 2

Version 5.0.1 has been release which includes the new packaging changes.

from angular-svg-round-progressbar.

DuncanFaulkner avatar DuncanFaulkner commented on June 10, 2024 1

I faced a similar issue when I upgraded to version 10 of Angular, I had to roll back to version 3.0.1 of the library, it does throw a warning about bailing out when optimising, but so far it seems to work.
I have submitted a PR (build-cleanup) which converted this library over to use the ng add schema and I'm waiting for @crisbeto to take it over the finishing line. This should then remove this error, I think this error is partly due the the build process and possibly commonJS issues but I'm not entirely sure about that.

from angular-svg-round-progressbar.

crisbeto avatar crisbeto commented on June 10, 2024

These errors usually mean that ngcc hasn't been run over the project's dependencies.

from angular-svg-round-progressbar.

gvlekke avatar gvlekke commented on June 10, 2024

@crisbeto good temporary fix but would be great if this library is supporting that.

Hope @DuncanFaulkner pr fixes it soon, altho I don't see his PR

from angular-svg-round-progressbar.

crisbeto avatar crisbeto commented on June 10, 2024

His changes are in the build-cleanup branch, but there's still some more work to be done.

from angular-svg-round-progressbar.

gvlekke avatar gvlekke commented on June 10, 2024

ah ok its still in the branch :) good luck and if you need some help testing give me a message.

from angular-svg-round-progressbar.

DuncanFaulkner avatar DuncanFaulkner commented on June 10, 2024

@crisbeto if there is anything I can help with to get this over the line?

from angular-svg-round-progressbar.

crisbeto avatar crisbeto commented on June 10, 2024

I'm really sorry that I didn't get to it, I had some time off the past couple of weeks but other things got in the way. What's holding it back is that I need to go through everything (production build, demo, GH pages deployment) and make sure that it works similarly to the current setup.

from angular-svg-round-progressbar.

DuncanFaulkner avatar DuncanFaulkner commented on June 10, 2024

No problem, we all need time to recharge the batteries, if it helps the process, the production code hasn't changed just the location of it (I don't recall making any changes to the code, but of course it still needs validating).

The new part was the creation of the ng add schema which will need full testing, and there may very well be bugs in that part.

The demo is just a regular angular app pulling in the component from library, I wasn't sure (at the time) how you were deploying it to GH pages and there will probably be some work to do here.

If there is anything I can help with please let me know.

from angular-svg-round-progressbar.

DuncanFaulkner avatar DuncanFaulkner commented on June 10, 2024

@crisbeto this is excellent news

from angular-svg-round-progressbar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.