Public header preprocessor directives about re HOT 6 CLOSED

the idea was that the application should include re.mk in its Makefile.
then the application will get the same flags as re. is this possible in your app ?

my goal is to reduce the number of #ifdef s.

for example the following defines might be subject to removal:

HAVE_INTTYPES_H
HAVE_INET6
HAVE_GAI_STRERROR

what do you think about remove these ?

the goal should be that the re API is source and binary compatible,
independently of which flags are set/unset.

from re.

is this possible in your app ?

I'm currently including it via CMake via the use of the pkgconfig file, so I don't think so. But perhaps CMake has a Makefile compatibility layer? No idea tbh. In any case, since re has a pkgconfig file, IMHO it should be striven for that the library can be used with pkg-config alone, essentially

cc foo.c `pkg-config --cflags --libs libre` -o foo

should work fine and not require foo.c to define HAVE_INTTYPES_H & co.

what do you think about remove these ?

That will probably resolve 90% of the issues but not all of them (like USE_ZLIB). I would also like an approach that resolves this issue 100% without generating any headers but at this point I'm uncertain whether that's possible. The alternative is of course to expose the defines directly in the pkgconfig file but that is a bit messy. Edit: This is actually what I've done in my Meson support branch for now (should I create a PR for that? 😉).

from re.

the pkg-config file is generated in Makefile:

libre.pc:
	@echo 'prefix='$(PREFIX) > libre.pc
	@echo 'exec_prefix=$${prefix}' >> libre.pc
	@echo 'libdir=$${prefix}/lib' >> libre.pc
	@echo 'includedir=$${prefix}/include/re' >> libre.pc
	@echo '' >> libre.pc
	@echo 'Name: libre' >> libre.pc
	@echo 'Description: ' >> libre.pc
	@echo 'Version: '$(VERSION) >> libre.pc
	@echo 'URL: http://creytiv.com/re.html' >> libre.pc
	@echo 'Libs: -L$${libdir} -lre' >> libre.pc
	@echo 'Libs.private: -L$${libdir} -lre ${LIBS}' >> libre.pc
	@echo 'Cflags: -I$${includedir}' >> libre.pc

so you could add all the mentioned flags to the Cflags section, would that work ?

from re.

Could do but the defines are not prefixed so they might clash. I guess it would be an adequate compromise for now.

from re.

@lgrahl are you planning to do any work on this ?

from re.

I have added the item to the roadmap:

https://github.com/creytiv/re/wiki/Roadmap

from re.