Code Monkey home page Code Monkey logo

Comments (7)

danielamiao avatar danielamiao commented on July 27, 2024 1

@crewjam Ah, I should have kept that PR opened, I closed it because we ended up using a fork. However, my original point is still valid, as per section 8.3.1 and 8.3.2 of the specifications:

  1. urn:oasis:names:tc:SAML:2.0:nameid-format:unspecified should be urn:oasis:names:tc:SAML:1.1:nameid-format:unspecified
  2. urn:oasis:names:tc:SAML:2.0:nameid-format:emailAddress should be urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress

from saml.

danielamiao avatar danielamiao commented on July 27, 2024

Running into the same problem, looks like a copy-and-paste error, unspecified and emailAddress are both defined in SAML 1.1 instead of 2.0 according to http://docs.oasis-open.org/security/saml/v2.0/saml-core-2.0-os.pdf

from saml.

meetmauro avatar meetmauro commented on July 27, 2024

I am getting this error too even though my request has a NameIDPolicy properly formatted.
My request is:

<samlp:AuthnRequest
   xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion" 
   xmlns:samlp="urn:oasis:names:tc:SAML:2.0:protocol" 
   ID="id-034bf268652648235617a4249a1d891d4698b4af" 
   Version="2.0" IssueInstant="2017-11-22T15:58:08.243Z" 
   Destination="https://adfs.service.com/adfs/ls/" ForceAuthn="false" 
   AssertionConsumerServiceURL="https://alba.group/saml/acs" 
   ProtocolBinding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST">
   <saml:Issuer Format="urn:oasis:names:tc:SAML:2.0:nameid-format:entity">https://alba.group/saml/metadata</saml:Issuer>
   <samlp:NameIDPolicy Format="urn:oasis:names:tc:SAML:2.0:nameid-format:transient" AllowCreate="true"/>
   <samlp:RequestedAuthnContext Comparison="exact">
      <saml:AuthnContextClassRef>urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport</saml:AuthnContextClassRef>
   </samlp:RequestedAuthnContext>
</samlp:AuthnRequest>

where I also added the RequestedAuthnContext thinking it was the source of the error (the XML does not validate against the SAML XSD without it) to no avail.
the response I get from ADFS is this one:

<samlp:StatusCode Value="urn:oasis:names:tc:SAML:2.0:status:InvalidNameIDPolicy" />

but why am I getting that error?
I also changed the code that @danielamiao suggested above but this not changing the response.

from saml.

crewjam avatar crewjam commented on July 27, 2024

I noticed #111 was closed. My read is that the name ID formats are correct. c.f. section 8.3.2 of http://docs.oasis-open.org/security/saml/v2.0/saml-core-2.0-os.pdf

from saml.

mrajashree avatar mrajashree commented on July 27, 2024

@meetmauro I have the exact same problem as you, were you able to resolve it?

from saml.

ricardofandrade avatar ricardofandrade commented on July 27, 2024

@crewjam Is it possible to get a fix for this?

from saml.

crewjam avatar crewjam commented on July 27, 2024

fixed in [6e8a81a]

from saml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.