Code Monkey home page Code Monkey logo

Comments (15)

dhruvkb avatar dhruvkb commented on June 30, 2024 2

The skill label generation has to work on all CC repositories, not just the first one. Also why just the first three technologies and not all of them?

Another important consideration is regarding language and framework/library. For example, someone who is quite familiar with JavaScript might still experience some problems if the issue is very Vue-oriented... so the frameworks have to be factored in when building labels.

from ccos-scripts.

Cronus1007 avatar Cronus1007 commented on June 30, 2024 2

@dhruvkb @Cronus1007

Because this repository is already written in Python, I don't think I'm going to approve any code written in JavaScript. Having 90% of the codebase written in Python and a single script written in JavaScript creates additional maintenance burden and complexity in the repository.

@zackkrida I agree with this part but in my #122 PR it is just a roght idea of the approach. But while merging I will make the transition from js to python.

from ccos-scripts.

kgodey avatar kgodey commented on June 30, 2024 1

I think it makes sense to build the skills based on .cc-metadata.yml and expand the technology list there.

I wonder if we could also encode branch protection in .cc-metadata.yml instead of storing it here, that way all configuration related to a repo could live in that repo. That should be a separate ticket though.

from ccos-scripts.

zackkrida avatar zackkrida commented on June 30, 2024 1

@dhruvkb @Cronus1007

Because this repository is already written in Python, I don't think I'm going to approve any code written in JavaScript. Having 90% of the codebase written in Python and a single script written in JavaScript creates additional maintenance burden and complexity in the repository.

@Cronus1007 if you'd like to attempt to work on this in Python, I'm sure our community on GitHub and Slack would be very willing to help you! Otherwise, unless @dhruvkb has opinions on why we should allow JavaScript, you're welcome to keep working on other issues. Thank you.

from ccos-scripts.

Cronus1007 avatar Cronus1007 commented on June 30, 2024

@dhruvkb Shall i implement this one.

from ccos-scripts.

dhruvkb avatar dhruvkb commented on June 30, 2024

Yeah @Cronus1007, please do! But let's start with a plan on how the .cc-metadata.yml file will look like before starting development.

from ccos-scripts.

Cronus1007 avatar Cronus1007 commented on June 30, 2024

@dhruvkb Here what I am planning that first of all let us make a request on https://api.github.com/orgs/creativecommons/repos and then get all the pinned repositories. Then we can proceed to get the first three most prioritized technologies of the pinned repos.

from ccos-scripts.

Cronus1007 avatar Cronus1007 commented on June 30, 2024

@dhruvkb Let me a build a seperate folder for this and initialize this project by eod or should I build a local repo.

from ccos-scripts.

Cronus1007 avatar Cronus1007 commented on June 30, 2024

Set the ADMIN_GITHUB_TOKEN environment variable with your GitHub token.
You will need a GitHub token with admin permissions to the creativecommons
GitHub organization.

Any opinoin regarding this?

from ccos-scripts.

dhruvkb avatar dhruvkb commented on June 30, 2024

@Cronus1007 you can create a test organisation on GitHub and use your own personal access token to test your scripts on it.

from ccos-scripts.

Cronus1007 avatar Cronus1007 commented on June 30, 2024

@dhruvkb Since I am much comfortable with javascript so shall I make a node app rather than django app.

from ccos-scripts.

Cronus1007 avatar Cronus1007 commented on June 30, 2024

I have made a test repo depicting the behaviour .
https://github.com/Cronus1007/testing

from ccos-scripts.

Cronus1007 avatar Cronus1007 commented on June 30, 2024

@dhruvkb I am able to write skills.json but due to some reason the api call is just restricted to first 30 repos of the cc organization. I may require some sort of help from your side to tackle this problem.
Screenshot from 2021-01-27 23-55-26

from ccos-scripts.

dhruvkb avatar dhruvkb commented on June 30, 2024

The package you are using for the API call might be paginated. Please open a draft PR so that we can take a closer look at your code.

from ccos-scripts.

Cronus1007 avatar Cronus1007 commented on June 30, 2024

@zackkrida @dhruvkb I am done with the #122 PR to automate the process and generating the required skills.json via python mainly and even left few comments upon the PR.

from ccos-scripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.