defaultChecked not working about grouped-checkboxes HOT 4 OPEN

Hi @seyade ,

The defaultChecked is not a property of Checkbox but instead of CheckboxGroup.
Applying defaultChecked to the checkboxGroup will check all checkboxes by default.

If you wish to check a single Checkbox you can simply pass checked to it.

from grouped-checkboxes.

Thanks @AlexLisenkov for replying. And great work by the way!

I think defaultChecked should also be applied to Checkbox as it is a supported props in React. For example I have a table full of checkboxes (about 50) in all columns and rows. I can populate the checkboxes with data from an api, but I also want to give users the choice to uncheck/check a populated checkbox. Using defaultChecked makes life easier in this context, I think.

from grouped-checkboxes.

Thank you for pointing out this issue, I believe there is something wrong with a Checkbox being controlled or not.

The misunderstanding, or flaw, is that the checked prop is now behaving like a defaultChecked. I agree with you, and the defaultChecked should be allowed and set the initial checked state.

If we add the defaultChecked there we will be left with the choice about what we should do with the checked prop.

1. Disallow (or ignore) the checked prop, making it impossible to control checked states. Checkboxes will always and only be controlled by the group.

2. Allow the checked prop, making it behave exactly like a checkbox. But making a checkbox controlled it will be impossible to make use of the allCheckers and noneCheckers, because they're not in charge of the state of a checkbox anymore.

Going for option 2 will be nice in a way that it will behave like a checkbox as how we're used to it. But it will also void the main feature of this package, easily add a checkbox to check all.

Can you give your opinion?

from grouped-checkboxes.

I guess, the most viable option will be to leave as it is since checked prop is the main prop for controlling state. Unless you give the user option to choose between defaultChecked and checked when necessary, but that will be too much for something simple like this.

from grouped-checkboxes.