Code Monkey home page Code Monkey logo

Comments (7)

crdoconnor avatar crdoconnor commented on May 18, 2024 1

Please make sure the PR comes accompanied with a story that verifies and describes the change though. E.g. modify this story: https://github.com/crdoconnor/strictyaml/blob/master/hitch/email-url.story

Thanks!

from strictyaml.

crdoconnor avatar crdoconnor commented on May 18, 2024 1

FYI i realized earlier that I hadn't been very clear about how to set up a development environment. If that's useful, I've written up instructions here: https://hitchdev.com/approach/contributing-to-hitch-libraries/

Anything that's not clear, doesn't work, etc. let me know. I haven't had many contributors before, so I'd like to smooth the process out. Thanks!

from strictyaml.

crdoconnor avatar crdoconnor commented on May 18, 2024 1

Ok cool. I'm closing this for now, but feel free to reopen if you have any new ideas or find anything else of interest.

from strictyaml.

crdoconnor avatar crdoconnor commented on May 18, 2024

Yep, I'd love that.

from strictyaml.

fkromer avatar fkromer commented on May 18, 2024

UNIX file path validation seems to be a bit tricky in practice. StrictYaml should probably only do plain syntax validation I guess. Means I wouldn't consider OS and filesystem specifics. Only / and NUL seem to be invalid UNIX file path characters (/ is name-separator character). However a regex like [^\0]+ (one or more characters not NUL) could raise a lot of false positives.

from strictyaml.

crdoconnor avatar crdoconnor commented on May 18, 2024

Interesting. I'm actually not even sure if a NUL character will parse in YAML (it probably shouldn't).

Either way, the fact that damn near everything is apparently a valid file path suggests that just using Str is probably the best approach.

from strictyaml.

fkromer avatar fkromer commented on May 18, 2024

I agree. I'll stick to Str syntax validation for now.

from strictyaml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.