IPP Calculation Errors about cqf-ruler HOT 18 CLOSED

from cqf-ruler.

More testing indicates the other measures ("bcs", "ccs", "col", "dms", "drr", "dsf", "pvs" ) aren't impacted by this.

MeasureId = asf
Measure = Measure/measure-asf
	denominator 2 = 15
	initial-population = 100
	numerator 2 = 15

MeasureId = bcs
Measure = Measure/measure-bcs
	denominator = 19
	initial-population = 19
	numerator = 7

MeasureId = ccs
Measure = Measure/measure-ccs
	denominator = 26
	initial-population = 26
	numerator = 16

MeasureId = col
Measure = Measure/measure-col
	denominator = 34
	initial-population = 34
	numerator = 9

MeasureId = dms
Measure = Measure/measure-dms
	denominator 3 = 17
	initial-population = 55
	numerator 3 = 17

MeasureId = drr
Measure = Measure/measure-drr
	denominator 3 = 13
	initial-population = 55
	numerator 3 = 4

MeasureId = dsf
Measure = Measure/measure-dsf
	denominator 2 = 66
	initial-population = 81
	numerator 2 = 63

MeasureId = pvs
Measure = Measure/measure-pvs
	denominator = 18
	initial-population = 18
	numerator = 7

from cqf-ruler.

Yeah, there was a bug in the CQL. I have fixed the CQL and updated the library in the last commit.

from cqf-ruler.

Did you update the hedis-ig project files too? Or, what's the best reference source for the various Measures and Libraries?

from cqf-ruler.

Unfortunately, the HEDIS IG is not building due to an issue with the publisher and npm package resolution. We have frozen commits to the repo while Grahame debugs the problem. For now, I am just updating the IG locally and will push everything once we're building again. For now, the best reference is the Ruler test suite.

from cqf-ruler.

Ok. I pulled the cqf-ruler version and it looks better. I notice the library ids have changed from "measure-asf-logic" to "library-asf-logic". Has the Measure reference changed too?

from cqf-ruler.

I do see the measure reference changed in the bundle as well. Should I be updating all of the libraries and measures from cqf-ruler now?

from cqf-ruler.

Until the HEDIS IG is back up, yes. That IG is considered the "source of truth" for those resources.

The resource ids should be the same as what is in the hedis-ig. And they look to be the same (https://github.com/cqframework/hedis-ig/blob/master/resources/library/library-asf-logic.json) ... at least for ASF.

from cqf-ruler.

I checked HEDIS IG and the measures still refer to "measure-xxx-logic" so I renamed the two from cqf-ruler and now the ASF IPP looks more reasonable. So closing this issue.

Measure = Measure/measure-asf
	denominator 2 = 15
	initial-population = 77
	numerator 2 = 15

from cqf-ruler.

Would you mind pointing me to where you are seeing these "measure-xxx-logic" references? I looked through all the Measures in the IG and they are all pointing to "library-xxx-logic" references.

from cqf-ruler.

from cqf-ruler.

from cqf-ruler.

Huh. Not sure why we're seeing different things. I see the following in the mrp measure:

"library": [
    {
      "reference": "Library/library-mrp-logic"
    }
  ],

from cqf-ruler.

Are you on the master branch?

from cqf-ruler.

from cqf-ruler.

Well that's bizarre and frustrating... =/

from cqf-ruler.

from cqf-ruler.

Good to know I am not losing my mind. =)

from cqf-ruler.