GitHub Actions fail to checkout repository about dbcsr HOT 8 CLOSED

yes, it seems so...
I discussed with @dev-zero . Ideally, it would be good to have an official fix, no workaround...

let's rely on daint for the moment...

from dbcsr.

ACK, i.e., if Daint-CI passes - PR can be merged.

from dbcsr.

Btw, rerunning failed actions does not help.

from dbcsr.

that's a fallout of a fix to the latest git CVE (and the git versions inside most of our build containers have been updated), I expect a general solution in the actions/checkout to appear soon'ish.

from dbcsr.

The issue is supposedly fixed (and already released upstream). I reran all failed tests for the (currently) latest merged commit (which passed at least Daint-CI for the merge), and everything seems to pass now except the test called "pre-commit" which is still failing:

fatal: unsafe repository ('/__w/dbcsr/dbcsr' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory /__w/dbcsr/dbcsr

This might be also because of simply rerunning tests for something committed before the fix.

from dbcsr.

The pre-commit check continues to fail even for new PRs.

from dbcsr.

I think the problem is the that here we are running the command:

pre-commit run --all-files || ( git status --short ; git diff ; exit 1 )

which includes git. I think we can add git config --global --add safe.directory for this stage. @dev-zero any idea?

from dbcsr.

@alazzaro yes, this seems to be the solution for now. Applied to both our pre-commit and as a step to the github pages deployment which suffers from the same issue.

from dbcsr.