A lot of bodies not closed about cozy-stack HOT 4 CLOSED

Hi, sorry for the delay.

I agree that we should close our Response.Body in production code. I have done it on the critical parts, like the connections to CouchDB, for the reasons you explain. But I have been more sloppy on other places.

I think one way we can advance on the subject could be:

1. fix the production code
2. enable the linter via another configuration file to disable running it on test files (temporary)
3. work on the tests to use httpexpect (I agree it improves tests)
4. when/if we can migrate all the tests, we can fusion the two configuration file for linters in one.

Are you OK with that?

from cozy-stack.

Hi 👋

My first message make the issue as terrible because the linter return a lot of errors but after a deeper look it seems that the linter have a lot of limitations. Id doesn't handle the body closed inside an another function.

So I totally agree with you plan, I had the same in mind but if we want to enable the linter in prod it would require to move the body closing next to the requests. This will make a lot of duplicate juste for making the linter happy.

Personnaly I think it's not terrible but it's still a good idea because this linter have a lot of value but this is your choice to make 😄

I will start to migrate the tests to httpexpect ASAP but it will take some time.

from cozy-stack.

It's done!

After a loooooong and tedious refactoring all the tests have moved on gavv/httpexpect and we can better see the actual bodyclose errors and hope to be able to activated soon.

Have a propose a bunch of PR which, once merged, should allow to enable the bodyclose linter and ensure that no body have been leaved unclosed.

from cozy-stack.

Final note: It seems that there is far fewer body not close than what I have expected. 95% of them was inside the tests.

from cozy-stack.