Comments (2)
Submodules are very convenient but introduce a bit of complexity in tracking latest changes, especially taking into account how the number of developers work on this project.
Having concrete version of the library helps to separate changes made in the app related to the library. Meaning if we see the app uses 0.0.2
then that code can access only that version of the lib.
In the case of submodules, you can't be sure what commit from the library was used to make changes in the app itself. It is solvable though. People have to pull the develop
branch of TCN library all the time but we lose that granularity using separate versions.
This is how I feel about but I'm open to discussion. For now I propose just use new version of TCN 0.0.3
.
from covidwatch-android-tcn.
Oh yeah, I hate submodules, but... I noticed they have made some improvements to them, and I wrote about it here over on the minimal repo:
covidwatchorg/covidwatch-android-minimal#1
I believe you can now pin them to branches but it seems to require users to INIT them correctly to maintain the link to the tracked commit. The stackoverflow page is really long and I skimmed it but it seemed to work for me.
Currently on the iOS version we just point to develop and if the build breaks we fix it, but it means we're up to date immediately.
Just a suggestion, since currently due to the lack of official tagging I guess the Android app has some changes to integrate the new version.
from covidwatch-android-tcn.
Related Issues (20)
- Fix Broken Unit Tests
- Simple Navigation Check
- In "Tested" workflow post contact, if I report positive, doesn't show in banner HOT 1
- Infrastructure for integration tests + example test
- Add Testing Documentation to README.md
- Update README.md / Docs HOT 2
- Integrate TCN Report REST change from Minimal App HOT 1
- test
- SonarCube fails on develop branch HOT 1
- Better error handling on failed `submitReport` requests HOT 1
- Deprecate ContactEvents... Files
- Add crashlytics to send error logs to Firebase HOT 2
- Figma 1.8 Changes HOT 1
- Long pull times on initial pull from Firebase
- Notification not working for me HOT 2
- tcn-client Tests Hanging on Github Actions HOT 2
- Add app localization HOT 1
- Build errors HOT 1
- [High Priority] Tapping on "others" when trying to share a positive diagnosis doesn't do anything HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from covidwatch-android-tcn.