Code Monkey home page Code Monkey logo

Comments (2)

Apisov avatar Apisov commented on August 22, 2024 1

Submodules are very convenient but introduce a bit of complexity in tracking latest changes, especially taking into account how the number of developers work on this project.

Having concrete version of the library helps to separate changes made in the app related to the library. Meaning if we see the app uses 0.0.2 then that code can access only that version of the lib.

In the case of submodules, you can't be sure what commit from the library was used to make changes in the app itself. It is solvable though. People have to pull the develop branch of TCN library all the time but we lose that granularity using separate versions.

This is how I feel about but I'm open to discussion. For now I propose just use new version of TCN 0.0.3.

from covidwatch-android-tcn.

madhavajay avatar madhavajay commented on August 22, 2024 1

Oh yeah, I hate submodules, but... I noticed they have made some improvements to them, and I wrote about it here over on the minimal repo:
covidwatchorg/covidwatch-android-minimal#1

I believe you can now pin them to branches but it seems to require users to INIT them correctly to maintain the link to the tracked commit. The stackoverflow page is really long and I skimmed it but it seemed to work for me.

Currently on the iOS version we just point to develop and if the build breaks we fix it, but it means we're up to date immediately.

Just a suggestion, since currently due to the lack of official tagging I guess the Android app has some changes to integrate the new version.

from covidwatch-android-tcn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.