Comments (2)
Hi @afinetooth.
Thanks a lot for the detailed explanation, very helpful! I'll troubleshoot the problem on our end, now that I know where to look.
from github-action.
Hi @id.
The explanation of this issue is complicated, and somewhat confusing due to a lot of seemingly related but ultimately irrelevant datapoints.
But the fix is simple, so let's start there and, if you want any further background, we can get into that.
Missing base build -> No PR Comment
Basically, in order to send a PR Comment, Coveralls needs to be able to find a PR build's base build---which is to say a coverage report for its base build---to which it compares the current build to derive a report showing the change in coverage between the two relevant commits.
That change in coverage is the key content of the PR Comment and when Coveralls can't find the base build, it can't derive the contents of the PR Comment and, as a result, it won't send one.
We are working on improvements to the UX of this scenario, which include a PR Comment with an exception message and a link to troubleshooting steps, but for the time being, your clue that this is your issue is that your PR build will read "** FIRST BUILD**" in the header of its build info table.
For example:
https://coveralls.io/builds/67917577
![Screenshot 2024-06-05 at 5 06 01 PM](https://private-user-images.githubusercontent.com/918667/337056405-bc6f63a0-9ab1-4248-b4f3-271926dd0235.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUxNzE2OTksIm5iZiI6MTcyNTE3MTM5OSwicGF0aCI6Ii85MTg2NjcvMzM3MDU2NDA1LWJjNmY2M2EwLTlhYjEtNDI0OC1iNGYzLTI3MTkyNmRkMDIzNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwMVQwNjE2MzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMjVmYWQ2ZTdmOWJjMTliYmMxOWU5NTU2NmM4ZWUzZDBmYzA2NWE1NWQ5ZTQwNzA2NGQ4ZWY0MTUyNDFmNDM2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.KBHW_rH-n3-7sW4cOJQmdWfs144EFcWngu8BxJk0r14)
Problem
While there appear to be a few issues with your builds, leading to misdirection, like the fact that the branch
name is missing from your push
builds:
![Screenshot 2024-06-05 at 4 47 31 PM](https://private-user-images.githubusercontent.com/918667/337056860-5b376673-3cbb-44c0-bef9-3cf639644bcf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUxNzE2OTksIm5iZiI6MTcyNTE3MTM5OSwicGF0aCI6Ii85MTg2NjcvMzM3MDU2ODYwLTViMzc2NjczLTNjYmItNDRjMC1iZWY5LTNjZjYzOTY0NGJjZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwMVQwNjE2MzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mNjRkNjNhMWUxYjQ4ZDc4MTFhMjlkMzI4MGZmMmE1YTk2ZjI5N2MxZDM2YWNkZWM1OGEwNmE0OGI2NTVhMDQ5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.IOR4M5VNuUPGh7dl2W_5ymriGOOZrv1wj6QWYSc1nU0)
Which points to a "git
hash" missing from your coverage reports that Coveralls integrations expect to pick up from the CI environment, but since your coverage reports still contain the minimum required git
data---commit_sha
:
![Screenshot 2024-06-05 at 5 49 07 PM](https://private-user-images.githubusercontent.com/918667/337057281-35d5dac2-3d1a-4476-8101-d2af97b3e0c2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUxNzE2OTksIm5iZiI6MTcyNTE3MTM5OSwicGF0aCI6Ii85MTg2NjcvMzM3MDU3MjgxLTM1ZDVkYWMyLTNkMWEtNDQ3Ni04MTAxLWQyYWY5N2IzZTBjMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwMVQwNjE2MzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03MTMyMTU3MGI2M2ZlMWZhZDE3OTQ2NmFmNTA0NWQ3YWEzMTU3ZWMzNzc2MGU0NjMxY2FiODUzNjA2YmJjZDBhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.dN6B2uKgaD_F2RVbPkKaWXpv0fYjE-4rIaaxxPpMNiQ)
This isn't your issue because the presence of commit_sha
allows Coveralls to find your PR builds' base builds.
Your problem is that your base builds were never completed.
In other words, your PR builds' base builds are in a state known as "pending completion" and, as a result, they do not appear in your official Build History and cannot be used for coverage calculations or comparisons.
Here is an example using the same PR build from above:
https://coveralls.io/builds/67917577
Here is the PR info we have from GitHub for that build:
PR Info:
{
"title": "ci: OTP 26 (26.2.5-1) for docker images",
"head": {
"sha": "c41be7ee22b310e46786116e20088b84bb528a3e",
"label": "zmstone:0605-otp26-for-docker-images",
"ref": "0605-otp26-for-docker-images"
},
"base": {
"sha": "ae0379f974a25f46ee7ba81d44c3dde68f18956e",
"label": "emqx:release-57",
"ref": "release-57"
}
}
Where "base"["sha"]
is the commit associated with your base build, and the one Coveralls is looking for, for comparison.
And that build exists:
Build.find(67917577).repo
=> #<GithubRepo id: 229018, name: "emqx/emqx" [...]
repo.builds.where(commit_sha: "ae0379f974a25f46ee7ba81d44c3dde68f18956e").first
=> #<Build id: 67904199, repo_id: 229018, [...] service_name: "github", [...] service_number: "9383783553", service_event_type: "push", [...] state: "pending" [...]
And here's the Coveralls build page for that build:
https://coveralls.io/builds/67904199
The problem is that it's pending completion---it's not finished / not completed, and its coverage was never calculated:
![Screenshot 2024-06-05 at 6 05 16 PM](https://private-user-images.githubusercontent.com/918667/337060563-e0ce8a34-0db7-4d3a-9040-579a49896a9c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUxNzE2OTksIm5iZiI6MTcyNTE3MTM5OSwicGF0aCI6Ii85MTg2NjcvMzM3MDYwNTYzLWUwY2U4YTM0LTBkYjctNGQzYS05MDQwLTU3OWE0OTg5NmE5Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwMVQwNjE2MzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03MWI2ZmQ2MzdiNDZmNThhOGM5NDE4NjRiOGM5ODA5Mjg0Mjc2MGYxNWY4YzJmNzJmMWNhNmQ4NTdmYzMxYjUyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.-BjXjayzTvi2Ptj27AtBA7qM8F6kvo_8T8pROjq4Gc4)
I'm not sure why this is, but the evidence points to these builds never fully uploading all of their expected parallel uploads (in your case 110 uploads), and, more to the point, never sending Coveralls the "close parallel build" signal, which means no steps in your Ci config ever called the (close) parallel build webhook.
Using this example, here's the PR build with 109 uploads (per my Admin info), which was completed:
https://coveralls.io/builds/67917577
![Screenshot 2024-06-05 at 6 07 10 PM](https://private-user-images.githubusercontent.com/918667/337061653-cc10ca52-e4d0-4fc5-81f7-86e8d659caa4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUxNzE2OTksIm5iZiI6MTcyNTE3MTM5OSwicGF0aCI6Ii85MTg2NjcvMzM3MDYxNjUzLWNjMTBjYTUyLWU0ZDAtNGZjNS04MWY3LTg2ZThkNjU5Y2FhNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwMVQwNjE2MzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05NTE0ODBhYzQ0M2QwMTVjYWNkZDdlMGJjYmVkZjg0ZmVkZTIzNjJiNjM0M2RmMTQwZWM5NTUyYmYyN2Q5NTFiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.WKJpgx9VcNFJh2-NoQceqc9rLkaM-w8bZKCFSoDSSs0)
And here's the base build, with only 105 uploads, and never completed:
https://coveralls.io/builds/67904199
![Screenshot 2024-06-05 at 6 10 17 PM](https://private-user-images.githubusercontent.com/918667/337062351-9097b697-799e-4a05-baad-79ba44f79b66.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUxNzE2OTksIm5iZiI6MTcyNTE3MTM5OSwicGF0aCI6Ii85MTg2NjcvMzM3MDYyMzUxLTkwOTdiNjk3LTc5OWUtNGEwNS1iYWFkLTc5YmE0NGY3OWI2Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwMVQwNjE2MzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zNzc0OTMzNjhhYTY5MGFhYmZhMDljNGMwMzY1ZWI1MzA1OTVkMjRkMjMwYTAwNTI5NDMyNjJiMTlkOGM2ZTNiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.o4XPhAKzkzffhcdCVwnujgCsmesdw-uI_3Gek99K__k)
To back that up, here's another example:
PR build with 109 uploads, completed:
https://coveralls.io/builds/67881752
![Screenshot 2024-06-05 at 6 18 14 PM](https://private-user-images.githubusercontent.com/918667/337064843-ae63203b-af09-4971-8e4c-054a74777950.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUxNzE2OTksIm5iZiI6MTcyNTE3MTM5OSwicGF0aCI6Ii85MTg2NjcvMzM3MDY0ODQzLWFlNjMyMDNiLWFmMDktNDk3MS04ZTRjLTA1NGE3NDc3Nzk1MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwMVQwNjE2MzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xOWYzNDY3OTg4OTUwYjAwMzM4M2Y4MzJiNmFlMzAyMzBjMmRjMTZjZDdhZDM2YmIwOTRjY2RlNjg1MzhkYWYxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.vkIp3HfpzWH39tNvhyZ20NdsCASChln6oglzFVbCLa8)
PR Info:
{
"title": "fix(resource manager): force kill process if stuck when stopping/removing",
"head": {
"sha": "f17aefe3d7746da91c917907536a7f6ae2b52317",
"label": "thalesmg:force-stop-connector-r57-20240604",
"ref": "force-stop-connector-r57-20240604"
},
"base": {
"sha": "cda6d5f63636199932d9c1015d690b011c46e243",
"label": "emqx:release-57",
"ref": "release-57"
}
}
Base build with 105 uploads, never completed:
https://coveralls.io/builds/67881435
![Screenshot 2024-06-05 at 6 19 44 PM](https://private-user-images.githubusercontent.com/918667/337065489-4cccdc6d-6eaf-4837-bf57-938ea8dc8601.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUxNzE2OTksIm5iZiI6MTcyNTE3MTM5OSwicGF0aCI6Ii85MTg2NjcvMzM3MDY1NDg5LTRjY2NkYzZkLTZlYWYtNDgzNy1iZjU3LTkzOGVhOGRjODYwMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwMVQwNjE2MzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hZDY1NzEyYmY4MWM5MGZkYmI0NmVmMDQ2NTMwMTBkNTZhNDI3MzAzMjlmNWNjOTQ0MjBmMTE5NTVhZGU5NjQ5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.PfGZNxfk7DPO3aEf-WLzO5JtMx7eWcgIooa9oxJeX6Q)
Fix
I assume that if you can figure out what's happening with those CI builds (from their build logs) in terms of why the uploads are stopping at 105, and why the (close) parallel build signal is never being sent, and fix that, you'll fix this problem.
If you have trouble figuring that out, please share the relevant portions of your CI build log(s), and, even better, if you can invoke debug
or verbose
mode that will help us both diagnose what's happening more easily. If you're using the Coveralls GitHub Action, just use the debug
input option:
- name: Coveralls Parallel Upload Step
uses: coverallsapp/github-action@v2
with:
flag-name: whatever
parallel: true
debug: true
And:
- name: Coveralls Close Parallel Build Step
uses: coverallsapp/github-action@v2
with:
parallel-finished: true
debug: true
from github-action.
Related Issues (20)
- coveralls doesn't recognize relevant lines, says coverage 100% HOT 1
- Pull request across forks shows 0 of 0 changed or added relevant lines in 0 files are covered HOT 1
- v2 sha256sum: unrecognized option: check HOT 1
- Support `git` workspace directory different from `GITHUB_WORKSPACE`.
- Update to Node 20 HOT 5
- Not working on Mac OS HOT 6
- Build failing with: "CoveragepyParser::ParserError:no such option: --data-file" HOT 1
- Python coverage support broken (v0.6.10 of coveralls report problem) HOT 9
- `pull_request_target` trigger is treated as `push` rather than a pull request
- Coveralls stopped working with no code changes in project HOT 4
- carryforward flag not working for one of my subprojects
- Version 0.6.11 broke our CI HOT 4
- Coveralls keeps posting PR coverage reports instead of editing the current one HOT 7
- file: and allow-empty: do not work together
- ⚠️ Internal server error. Please contact Coveralls team. / report submission fails for external contributors HOT 6
- Support GitHub Actions ARM runners HOT 11
- Coveralls: command not found HOT 7
- error while loading shared libraries: libevent-2.1.so.7 HOT 4
- Change 504 error page/handling to not dump 3/4mb of content (700k of which is base64 noise) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-action.