target `build` in Makefile did not explicit depend on the code. about gaia HOT 5 CLOSED

Does it duplicate with #26 ?

from gaia.

@yangyanqing another C fella here ;-)

The Go compiler works in a different way than C compilers - build artifacts are cached and reused by default in future builds, unless cache is turned off explicitly by setting GOCACHE=off in the environment. You may find out where the compiler caches objects by typing go env GOCACHE.

Since the adoption of go modules, turning the cache off causes the build to fail:

$ GOCACHE=off make install
go install -mod=readonly -tags "netgo ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=gaia -X github.com/cosmos/cosmos-sdk/version.ServerName=gaiad -X github.com/cosmos/cosmos-sdk/version.ClientName=gaiacli -X github.com/cosmos/cosmos-sdk/version.Version=0.0.0-15-g787bd94 -X github.com/cosmos/cosmos-sdk/version.Commit=787bd94b3134ba334e1162afcf77bbe8dcf66644 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger"' ./cmd/gaiad
build cache is disabled by GOCACHE=off, but required as of Go 1.12
Makefile:84: recipe for target 'install' failed
make: *** [install] Error 1

If you want to make sure to recompile all build artifacts, you first need to call go clean -cache.

from gaia.

I know how to do this - it's more a question of how needed this is cause a mitigation is in place:

make clean build

This way you can make sure you recompile everything

from gaia.

I was a C engineer for more than 8 years. C project will compile each .c to .obj, and link them to executable file. There are tens of millions of lines of code in my project. When I modify a single file, make can find it accurately. Compiling can finish in one minute. But if I clean all target, I have to wait for more than 40 minutes.

I cannot find some intermediate file like obj in go build system. So maybe make clean build and make build will spend the same time. If the project grow grow to a larger scale, compile time will be longer and longer.

from gaia.

Thank you for taking the time to file this report and helping to make gaia better. I'm closing it as it does not seem to be causing significant problems for now.

from gaia.