Comments (6)
Ref: #7 (comment)
from journal.
API endpoint: https://github.com/coronasafe/journal/blob/develop/doc/api.md#routemap-for-a-user
from journal.
@unnitallman We need to consolidate the two APIs required here. The current API flow dictates two steps:
- search for user using phone number and date of birth
- use the returned user ID to fetch routes.
But since phone number is unique in the first place, the search makes no sense, also with a user id that can be guessed, it's opening up the second API to search all users.
Instead we need to have a single API that can look up the user by phone number and date of birth, return user details (the name just for confirmation that admin has the right user) and route map.
from journal.
@agneym The user table uses integer
ids. That is not a good thing and thats what makes it "guessable". I will change it to uuid
. If so do you think, we will still need to merge the two APIs ? its not difficult to do, just let me know.
from journal.
#65 converts ID of user table from integer to UUID. Haven't merged it yet. Once this is done, existing database will need to reset using ./bin/setup
since user -> visit relationships will be affected by this change.
from journal.
That sounds fine for now, we can review the UI later if necessary
from journal.
Related Issues (20)
- [DepShield] (CVSS 5.3) Vulnerability due to usage of kind-of:3.2.2 HOT 1
- [DepShield] (CVSS 7.5) Vulnerability due to usage of acorn:6.4.1 HOT 1
- [DepShield] (CVSS 7.4) Vulnerability due to usage of lodash.toarray:4.4.0 HOT 1
- [DepShield] (CVSS 7.4) Vulnerability due to usage of lodash.memoize:4.1.2 HOT 1
- [DepShield] (CVSS 7.4) Vulnerability due to usage of lodash.uniq:4.5.0 HOT 1
- [DepShield] (CVSS 7.4) Vulnerability due to usage of lodash._reinterpolate:3.0.0 HOT 1
- [DepShield] (CVSS 7.4) Vulnerability due to usage of lodash.get:4.4.2 HOT 1
- [DepShield] (CVSS 7.5) Vulnerability due to usage of debug:2.6.9 HOT 1
- [DepShield] (CVSS 7.5) Vulnerability due to usage of q:1.5.1 HOT 1
- [DepShield] (CVSS 7.5) Vulnerability due to usage of express:4.17.1 HOT 1
- [DepShield] (CVSS 5.3) Vulnerability due to usage of kind-of:5.1.0 HOT 1
- [DepShield] (CVSS 7.5) Vulnerability due to usage of http-proxy:1.18.1 HOT 1
- [DepShield] (CVSS 5.3) Vulnerability due to usage of kind-of:4.0.0 HOT 1
- Different use case
- List all establishments in admin dashboard HOT 1
- Merchant should be able to select local body on registration HOT 2
- Admin should be able to select from and to date for route map HOT 2
- Signup image thumb to SVG HOT 1
- Add page titles
- How to debug Ruby foreman project?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from journal.