Review abstraction levels of services about cwa-verification-server HOT 5 OPEN

This would be really welcoming, since moving parts of controller logic into the service and if necessary in further classes to get a good encapsulation and readability.

For example take

• generateRegistrationToken(...) - checking for keyType and perform actions on it. Method is doing multiple things based on the keyType. (Reference: Robert C. Martin , Clean Code. Chapter 3 Functions)

• generateTan(...) - same as above mentioned. Mixing level of abstraction.

from cwa-verification-server.

This would be really welcoming, since moving parts of controller logic into the service and if necessary in further classes to get a good encapsulation and readability.

For example take

• generateRegistrationToken(...) - checking for keyType and perform actions on it. Method is doing multiple things based on the keyType. (Reference: Robert C. Martin , Clean Code. Chapter 3 Functions)
• generateTan(...) - same as above mentioned. Mixing level of abstraction.

Dear @anjeyy , I would like to make this code refactor if possible.

from cwa-verification-server.

This would be really welcoming, since moving parts of controller logic into the service and if necessary in further classes to get a good encapsulation and readability.
For example take

• generateRegistrationToken(...) - checking for keyType and perform actions on it. Method is doing multiple things based on the keyType. (Reference: Robert C. Martin , Clean Code. Chapter 3 Functions)
• generateTan(...) - same as above mentioned. Mixing level of abstraction.

Dear @anjeyy , I would like to make this code refactor if possible.

@alstiefel @dfischer-tech @f11h @jhagestedt @mlaue-tech @mschulte-tsi @tence @kreincke @ascheibal @BugBuster1701

Is it possible to accept me as a contributor, please? Even though I am a beginner in open source project, I would be very grateful for you acception. Thanks in advance!

from cwa-verification-server.

Hi @damirseit,
I see, that you already forked the verification server. You can apply your changes to your private copy and then make a pull request to get your changes accepted for the official main branch. That would also identify you as an official contributor.
Would this work for you?

from cwa-verification-server.

Hi @damirseit, I see, that you already forked the verification server. You can apply your changes to your private copy and then make a pull request to get your changes accepted for the official main branch. That would also identify you as an official contributor. Would this work for you?

Yes, thank you very much! I already made a pull request. Would be extremely grateful for your feedback. Thanks in advance!

from cwa-verification-server.