dicomParser Does not work with electron. about dicomparser HOT 5 CLOSED

Hi there - sorry for the delay on this. I am not sure what change you are suggesting here, the code you included is calling factory() twice. Perhaps you can submit a PR that includes a test for electron?

from dicomparser.

Any update on this? Unfortunately I haven't had time to play with electron yet :(

from dicomparser.

FYI I use node and I don't have any problem using it however I just use node modules. Bower components tend to be more of a pain at this point in my life.

from dicomparser.

Hi Chris. Just got back on this project. I'm using nodejs + electron, therefore statement if (typeof module !== 'undefined' && module.exports) { evaluates to true. However module.exports = factory(); is not accessible in electron viewer since it is isolated from the underlying nodejs process. For my case, there is no harm in calling factory() twice.

Is there anything wrong with assigning both module.exports anddicomParser the same thing?

// node.js
    if (typeof module !== 'undefined' && module.exports) {
        module.exports = dicomParser = factory();
    }

from dicomparser.

This seems to work fine for me. I just tested it in main.js and in renderer.js using the electron-quick-start application.

const dicomParser = require('dicom-parser');

from dicomparser.