Commit breaks my code :( about dicomparser HOT 5 CLOSED

@leonardorame According to the DICOM standard, if a sequence has an explicit length of 0, then it shouldn't be followed by a sequence delimitation tag (section 7.5.2 in part 3.5) so it looks like that's invalid DICOM. dicomParser does have code to handle empty sequences, both in the case of explicitly defined length and implicitly defined length. In fact, I just wrote a couple of tests that have empty sequences like what's in your file and they passed. Is there any way you can attach one of the problematic data sets and we can take a look at it to see what's going on?

from dicomparser.

@yagni, yes, let me anonymize on of those files and I'll upload somewhere to let you check.

from dicomparser.

@yagni mm, wait, I've donwloaded one of those files, then tested it using https://rawgit.com/chafey/dicomParser/master/examples/dragAndDropDump/index.html and it was parsed without issue. Does that example uses your latest code?.

from dicomparser.

@leonardorame Yes, that's synced up with the latest release so it has my item tag check code in it.

from dicomparser.

Ok, it looks like the problem comes from cornerstoneWADOImageLoader in combination with the new dicomParser.

I'm closing this to continue here: cornerstonejs/cornerstoneWADOImageLoader#33

from dicomparser.