Handling DICOM with empty Sequence about dicomparser HOT 9 CLOSED

What do you mean by incomplete data set? Does it throw an exception? Any chance you can share the file? DICOM Sequence code is complex and it is possible there is a bug in the library. It is also possible that the file is not valid DICOM

from dicomparser.

There is no exception and I'm not sure if I can share the file. I think you're correct that it is an invalid DICOM file. I ran the file against the dciodvfy tool and I get this error.

Error - Bad Sequence number of Items 0 (1 Required by Module definition) Element=<ReferencedPerformedProcedureStepSequence> Module=<EncapsulatedDocumentSeries>

This doesn't seem like a bug. I am ok with you closing the issue since it is invalid DICOM but it seems like other tools deal with this situation in another way. Here is a fragment of the DICOM dump that I get while using the dcmdump tool.

...
(0008,1111) SQ (Sequence with undefined length #=0)     # u/l, 1 ReferencedPerformedProcedureStepSequence
(fffe,e0dd) na (SequenceDelimitationItem)               #   0, 0 SequenceDelimitationItem
(0010,0010) PN [name]                                   #  12, 1 PatientName
(0010,0020) LO [1]                                      #   6, 1 PatientID
...

When I use the dicomParser or use your DICOM dump example page the data set ends with the ReferencedPerformedProcedureStepSequence. It never gets to the patient information because it never finds the ItemDelimitationItem.

Thanks again.

from dicomparser.

The error you listed appears to be at a higher level than parsing the byte stream ( I am guessing that 0008,1111 is expected to have a value for this SOP Class). I believe that DICOM standard allows sequences with zero items which is what this appears to have and dicomParser should continue parsing to the subsequent elements. If you can provide the file, I'll take a look - or if not, you can try to debug and submit a PR. Going to keep this open until we can be sure there is no issue in the dicomParser

from dicomparser.

Any update on this? Let me know if you need help getting started with debugging dicomParser

from dicomparser.

Sorry for the delay Chris. I will send you the dicom file that is causing this issue to your gmail address.

from dicomparser.

Hi Harry,

Thanks for sending the file, I will take a look at it this weekend.

Chris

On Wed, Jul 1, 2015 at 3:54 PM, Henry Q. Dineen [email protected]
wrote:

Sorry for the delay Chris. I will send you the dicom file that is causing
this issue to your gmail address.

—
Reply to this email directly or view it on GitHub
#18 (comment).

from dicomparser.

I haven't gotten to this yet - been crazy busy. Might be another week or so - sorry!

from dicomparser.

Just submitted some fixes for this, please try it and let me know

from dicomparser.

Awesome. This fixes the issue for me.

from dicomparser.