interactive live ISO experience no longer works with Ignition 2.4.0 about fedora-coreos-config HOT 7 CLOSED

Folded a fix for this into #426.

Thanks @jlebon

One suggestion was to use the structured journal messages ignition logs now but that gets tricky because we're running in a generator.

What's tricky about querying the journal from a generator?

I just wasn't sure if it would work or not, or cause other problems. Looks like it works 🎉

from fedora-coreos-config.

cc @bgilbert. We should get this fixed before the testing release.

from fedora-coreos-config.

One suggestion was to use the structured journal messages ignition logs now but that gets tricky because we're running in a generator. Obviously one solution may be to hoist this stuff into a different place so we don't have that limitation.

from fedora-coreos-config.

Whoops, didn't catch that implication when writing the PR sorry.

One alternative could be to temporarily have Ignition write out a separate file indicating that there was no user configuration. Or we could have a fetch-style stage that could exit depending on whether or not there is a provider / user config defined which we could call in the detection script.

from fedora-coreos-config.

One suggestion was to use the structured journal messages ignition logs now but that gets tricky because we're running in a generator.

What's tricky about querying the journal from a generator?

(The reason this works is because this generator is running in the real root, Ignition runs in the initrd, so it's not going to race or anything)

from fedora-coreos-config.

Folded a fix for this into #426.

from fedora-coreos-config.

One thing related to this is that we should fix (or check if it's already fixed by the recent work to close races) the iso-live-login scenario in testiso and turn that on in CI for this repo (and really, all the default testiso scenarios).

from fedora-coreos-config.