Code Monkey home page Code Monkey logo

Comments (6)

jschintag avatar jschintag commented on July 17, 2024 1

I will take a look at it tomorrow. I'm leaning towards making the test ignore other warnings, that way it is more resillient to changes.

from fedora-coreos-config.

jschintag avatar jschintag commented on July 17, 2024 1

Here is the promised PR to improve the test #1715 for now

from fedora-coreos-config.

dustymabe avatar dustymabe commented on July 17, 2024

For this particular test we are trying to verify that the warning we expect gets surfaced to CLHM. What we don't account for is that other warnings may also be in the CLHM (this doesn't happen on x86_64 and aarch64).

We can adapt the test to be less strict about warnings showing up that we don't expect.. Or we could adapt the test to expect a different output on ppc64le and s390x qemu.

from fedora-coreos-config.

cgwalters avatar cgwalters commented on July 17, 2024

I don't understand why Ignition is warning here - why is the virtio thing still experimental? Us emitting warnings about something the user didn't in any way do is just going to lead to confusion and concern on their part.

from fedora-coreos-config.

dustymabe avatar dustymabe commented on July 17, 2024

I don't understand why Ignition is warning here - why is the virtio thing still experimental? Us emitting warnings about something the user didn't in any way do is just going to lead to confusion and concern on their part.

We should probably drive to a conclusion in coreos/ignition#999

from fedora-coreos-config.

dustymabe avatar dustymabe commented on July 17, 2024

Should issues like this be opened against the top level issue tracker? If agreed I'll move it over there.

from fedora-coreos-config.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.