Code Monkey home page Code Monkey logo

Comments (7)

rfairley avatar rfairley commented on August 15, 2024 1

SGTM to make the change now! I will start on changing the source, and should have a PR today or tomorrow.

from console-login-helper-messages.

dustymabe avatar dustymabe commented on August 15, 2024

has the upstream source changed any?

from console-login-helper-messages.

rfairley avatar rfairley commented on August 15, 2024

It seems there is now support for /run/issue{.d}, /usr/lib/issue{.d}, and util-linux-2.35 is available in Fedora >= 32.

We can have c-l-h-m in Fedora use /run/issue.d for the snippet it writes (currently it writes into /run/console-login-helper-messages), and have this change in a new release of c-l-h-m timed after Fedora 32 is officially released. For backwards compatibility for systems with a util-linux version below 2.35, a command line option like issuegen --legacy could be available to keep using the private directory.

from console-login-helper-messages.

dustymabe avatar dustymabe commented on August 15, 2024

WDYT about go ahead and modify the sources now and do a new release and we can just build it for f32+ ?

from console-login-helper-messages.

dustymabe avatar dustymabe commented on August 15, 2024

the fedora cloud base image uses c-l-h-m already so we can test it there and we have a next stream coming in Fedora CoreOS that can go ahead and take advantage of it

from console-login-helper-messages.

rfairley avatar rfairley commented on August 15, 2024

With the updated util-linux, the current logic is that /run/issue and /run/issue.d will only be searched if /etc/issue is not present. Reference: util-linux/util-linux@456bcbc#diff-1a88921242270a199a0c569fd343b41fR357 (also tried locally). For now, I'll leave the symlink from /etc/issue.d to the location under /run in place.

It may be feasible to modify agetty with an option to override this behavior and display multiple issue paths - opened an issue for this: util-linux/util-linux#1041

from console-login-helper-messages.

kelvinfan001 avatar kelvinfan001 commented on August 15, 2024

Option in agetty to override this behavior and display multiple issue paths is now in util-linux release 2.36

from console-login-helper-messages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.