Undefined names: run_live() and linear_dir about real-time-voice-cloning HOT 6 CLOSED

Oh yeah these are functions from Rayahane's tacotron implementation that I've butchered away. I'm not religious on flake8 but I guess it wouldn't hurt to clean some things up. I'll see to it.

from real-time-voice-cloning.

Thx.

from real-time-voice-cloning.

I'm not religious on flake8

Me neither but I do like --select=E9,F63,F72,F82. Most of the others are mere "style violations" that can be autofixed with a run of python/black.

from real-time-voice-cloning.

Well thank you for looking into it. I've fixed those in 0908e4d.

I do think that some of the thousand style violations are problematic. E.g. I've been trying to fix (manually) the inconsistent indents in Rahayne's code and the character limits being broken everywhere, and I didn't think of using a tool that would automate that. I will look into using black, but I feel like I might regret it if I change a thousand lines at once and if I don't look at the diff after (I assume that the semantics are not changed, but still). Since you seem to have experience with that, do you think that's it's the right approach?

from real-time-voice-cloning.

If you are doing this by hand then check out https://black.readthedocs.io

You could do just the worst files or the worst directories.

from real-time-voice-cloning.

Nice work.

Yes the semantics are not changed by black.

from real-time-voice-cloning.