JSON::ParserError when draft_destroying a widget which was just created about draftsman HOT 3 CLOSED

I think I traced this issue, and might have a potential fix. If you think this is the right fix, I'm happy to submit a PR.

In the draft_destroy method, the previous_draft is set, but the attributes are always serialized (even if they're JSON). See https://github.com/liveeditor/draftsman/blob/master/lib/draftsman/model.rb#L234

I would propose changing the conditional to:

if self.draft?
  attrs = send(self.class.draft_association_name).attributes
  data[:previous_draft] = self.class.draft_class.object_col_is_json? ? attrs : Draftsman.serializer.dump(attrs)
end

I believe this fixes the issues that I've been seeing. Does that seem about right to you?

from draftsman.

Can you try the latest from master and let me know if that fixes it?

Thanks for pinpointing it. I ended up creating a previous_draft_col_is_json? class method on Draftsman::Draft just to make sure it always does the right thing.

Oh, I like what you did with the attrs local variable, so I'll commit that in now too.

Thanks again. Made it much easier for me to fix!

from draftsman.

Yep, this works as well. Thanks for putting in the fix!

from draftsman.