Code Monkey home page Code Monkey logo

Comments (11)

theawesomew avatar theawesomew commented on May 27, 2024 1

If you're interested in making a contribution, you're very welcome to fork the repository and make a pull-request. I'm the administrator of this repository and I welcome any and all contributions!

This link should help get you started :)

from website.

theawesomew avatar theawesomew commented on May 27, 2024 1

I agree with Nick's idea to add more padding below the 404 PAGE NOT FOUND text but, I disagree with removing the 'return to home' button - I feel that's a more ergonomic way of addressing people thought of 'Oh, where do I go next then?' which is - to me - a natural question after finding that the page you're looking for no longer exists or never did. So, leave that there - otherwise, it's looking pretty good currently.

from website.

scorpiontornado avatar scorpiontornado commented on May 27, 2024

To replicate, go to https://coopsoc.com.au/a

Should just be a simple change to the CSS (change background colour to white, and possibly text colour, text size, and/or position of the 404 message). Could add a little question mark icon if you're feeling fancy. Also change the colour of "Copyright © 2022 UNSW Co-op Society" to black to be consistent with the other pages.

from website.

vishalpawarR avatar vishalpawarR commented on May 27, 2024

@scorpiontornado I want help can you let me know where to make change in which file?? Beginner OS contributor!

from website.

lhvy avatar lhvy commented on May 27, 2024

Nick and I started working on this. Currently have a new 404 page created, just making it look ✨pretty✨.

from website.

scorpiontornado avatar scorpiontornado commented on May 27, 2024

@scorpiontornado I want help can you let me know where to make change in which file?? Beginner OS contributor!

Sorry, this turned out to be a bit more complicated than I was expected (turns out its currently using the default next.js 404 page, so its not just changing a small bit of CSS like I thought). We're working on it now, but feel free to have a go at another issue!

from website.

lhvy avatar lhvy commented on May 27, 2024

image

Thoughts on this 404 page? I added the return home button, but I'm wondering if I could just make the 404 text/icon larger and simply let the user click on any of the items in the nav bar instead.

from website.

scorpiontornado avatar scorpiontornado commented on May 27, 2024

Yeah I don't think we need an explicit return home button, the logo in the nav bar already does that (might be a bit unintuitive for some users but I think most ppl know to click on a logo or one of the other pages in the nav bar). Some small nitpicks though - maybe add a bit more padding between the not found message and the magnifying glass. Also, you could either centre both the message and magnifying glass vertically, or add a bit more padding before the message. Could also consider making the magnifying glass bigger and/or putting it before the message.

from website.

scorpiontornado avatar scorpiontornado commented on May 27, 2024

Yo @lhvy could you MR this

from website.

lhvy avatar lhvy commented on May 27, 2024

Yeah sure, not sure what the holdup was, I'll have to check again but I should have something good enough anyway. (Also lol someone's spent too long on GitLab)

from website.

scorpiontornado avatar scorpiontornado commented on May 27, 2024

@lhvy could you check if this is ready to merge?

from website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.