Code Monkey home page Code Monkey logo

Comments (18)

shams-ahmed avatar shams-ahmed commented on July 21, 2024

submitted a pull request to cocoa pods for this project, takes all the source files from RMDateSelectionViewController folder!!

from rmdateselectionviewcontroller.

CooperRS avatar CooperRS commented on July 21, 2024

CocoaPods support would be great! Unfortunately, I am not using CocoaPods and thus I have no idea what I need to do to support it. If you tell me, I will integrate it ;)

from rmdateselectionviewcontroller.

shams-ahmed avatar shams-ahmed commented on July 21, 2024

I see you made a pull request so your on the right track, here a quick guide http://docs.cocoapods.org/guides/contributing_to_the_master_repo.html

from rmdateselectionviewcontroller.

CooperRS avatar CooperRS commented on July 21, 2024

Yep, already read that tutorial.

Unfortunately, the automatic test script fails with errors like "Could not find property maskToBounds". I already imported <QuartzCore/QuartzCore.h> but the error remains. Any ideas?

from rmdateselectionviewcontroller.

shams-ahmed avatar shams-ahmed commented on July 21, 2024

has this been imported in .h file

from rmdateselectionviewcontroller.

CooperRS avatar CooperRS commented on July 21, 2024

Here is the link to some details: https://travis-ci.org/CocoaPods/Specs/builds/13463702

Is there a way to restart the test?

from rmdateselectionviewcontroller.

CooperRS avatar CooperRS commented on July 21, 2024

Imported it to RMDateSelectionViewController.m. But it forgot to push my changes to this project before I made the Pull request...

from rmdateselectionviewcontroller.

shams-ahmed avatar shams-ahmed commented on July 21, 2024

I think it doesn't like your forward class declaration

from rmdateselectionviewcontroller.

CooperRS avatar CooperRS commented on July 21, 2024

CALayer is just a forward declaration because <QuartzCore/QuartzCore.h> is not imported. I have no idea why this is. I have committed another Pull Request and this time my additional import should have been considered by the automatic build script. But it failed again: https://travis-ci.org/CocoaPods/Specs/builds/13464892

I have no idea, why it does not work. Any ideas?

from rmdateselectionviewcontroller.

shams-ahmed avatar shams-ahmed commented on July 21, 2024

do: pod spec lint --no-clean

in finder locate /tmp folder. that should have the xcode build might come up with errors

from rmdateselectionviewcontroller.

shams-ahmed avatar shams-ahmed commented on July 21, 2024

also delete cache cocoaSpec folder in /tmp so terminal can compiler a fresh build

from rmdateselectionviewcontroller.

CooperRS avatar CooperRS commented on July 21, 2024

Already did that, but that works just great.

141-187:RMDateSelectionViewController CooperRS$ pod spec lint --no-clean

 -> RMDateSelectionViewController (0.9)

Pods project available at `/tmp/CocoaPods/Lint/Pods/Pods.xcodeproj` for inspection.

Analyzed 1 podspec.

RMDateSelectionViewController.podspec passed validation.

from rmdateselectionviewcontroller.

CooperRS avatar CooperRS commented on July 21, 2024

Ah ok, got the next error. Let me fix that :D

from rmdateselectionviewcontroller.

CooperRS avatar CooperRS commented on July 21, 2024

Yay! Did it: https://travis-ci.org/CocoaPods/Specs/builds/13466487

from rmdateselectionviewcontroller.

shams-ahmed avatar shams-ahmed commented on July 21, 2024

great!!

what was the issue?

from rmdateselectionviewcontroller.

CooperRS avatar CooperRS commented on July 21, 2024

I had to do the additional import but that import was never considered by the automatic build script because it always used the tag 0.9 which did not include the additional import. So I created a new tag 0.9.1 which includes the cocoa pods support and the additional import. That now works. How long have I to wait before my pull request is being accepted?

from rmdateselectionviewcontroller.

shams-ahmed avatar shams-ahmed commented on July 21, 2024

alright! doesn't take too long probably some time today

from rmdateselectionviewcontroller.

CooperRS avatar CooperRS commented on July 21, 2024

Pull request has been merged -> Closed
CocoaPods/Specs#5184

from rmdateselectionviewcontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.