Comments (5)
@dezmathio we have re-defined parse_markdown in a new helper in the project to to this.
from contentful_rails.
I see, we thought of doing that as well. Do you think that it would be worthwhile making a configuration attribute such as .markdown_renderer
where we could override it if we were using a subclassed one, else it would always use the default one? That way we could cut down on code duplication & have a somewhat cleaner solution. Thoughts? cc @pmoore
from contentful_rails.
I'll leave @dlitvakb to decide, @dezmathio - he maintains now.
from contentful_rails.
Hey @dezmathio,
Looks like something we can improve on,
I'll look onto it as soon as I have a free slot on my schedule.
I'll propose taking a look again to refining this gem during next week's planning.
I'll try to get you an update by this time next week.
Cheers
from contentful_rails.
Hey @dezmathio,
Sorry response took a bit longer, I've been travelling quite a bit (right now at RubyConf US).
My first priority now is to address all Rails Integration related issues, including this one, so I'll be tackling this issue in the next few days and have a PR ready for merge as soon as possible.
Cheers
from contentful_rails.
Related Issues (20)
- Concern with `eager_load!` HOT 14
- Missing attr_writer for attributes with nil values HOT 3
- #delete_matched not supported by all ActiveSupport cache types HOT 2
- alias_method_chain call in timestamps.rb causes deprecation warning HOT 4
- this thing work? HOT 10
- Rails 5 support? HOT 1
- enable caching support HOT 7
- Can't load gem without ActiveRecord HOT 6
- Webhooks Rails 5 HOT 6
- Webhooks fail in Rails 5.1 HOT 2
- Content types caching blowing up VCR on CI HOT 1
- Release webhooks fix? HOT 1
- Load error HOT 5
- Support Contentful Model 1.0 HOT 2
- OOM errors in Docker HOT 9
- Webhook Engine does not provide the /debug route as expected HOT 1
- How do you perform the russian nesting doll cache?
- "Only Redis glob strings are supported: " on unpublish when using redis as cache store
- Eager load in a to_prepare block
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from contentful_rails.