Right now we check how many results are returned by the query, if positive (>0) then a rollback is initiated.
Would be useful to have a flag called --expected-result-count which can override this value.

Refs:

• Prometheus: https://github.com/ContainerSolutions/helm-monitor/blob/master/cmd/monitor_prometheus.go#L134
• ElasticSearch: https://github.com/ContainerSolutions/helm-monitor/blob/master/cmd/monitor_elasticsearch.go#L152

Discussion: #1

Currently, the entire query logic is stored in the ./cmd/monitor_*.go files. We need this logic in a dedicated package under a ./pkg directory.

Hi!
I'd like to file a feature request to support Application Insights.
Thanks in advance.

Hello 👋

I run a security community that finds and fixes vulnerabilities in OSS. A researcher (@arshadkazmi42) has found a potential issue, which I would be eager to share with you.

Could you add a SECURITY.md file with an e-mail address for me to send further details to? GitHub recommends a security policy to ensure issues are responsibly disclosed, and it would help direct researchers in the future.

Looking forward to hearing from you 👍

(cc @huntr-helper)

Does helm-monitor currently support multiple queries? Meaning, instead of just checking for example http 500, can we also check for latency going up etc? Would that be done just by executing another helm-monitor command?

Hi, I am trying to monitor my helm releases with this awesome plugin, but I am trying to query an ES server that is external outside my k8 cluster, its on the same network though. This is the command I am trying:

helm monitor elasticsearch --elasticsearch=https://$ES_SERVER_URL:9200 "$APP_NAMESPACE" 'kubernetes.namespace:ecommerce-registryv2-uat AND message:"Error creating bean'

And I get this error:

x509: certificate signed by unknown authority

So I am trying to some how ask helm monitor to ignore the cert on that ES, but I am not sure how to do that.

You help will be much appreciated.

Add Sentry support, see https://docs.sentry.io/api/

Hi, I am trying to use the plugin but I get the following error.

$ helm plugin install https://github.com/ContainerSolutions/helm-monitor
/usr/bin/wget
Connecting to github.com (192.30.253.112:443)
Connecting to github-production-release-asset-2e65be.s3.amazonaws.com (52.216.224.32:443)
helm-monitor_linux_0   8% |**                             |   339k  0:00:11 ETA
helm-monitor_linux_0  38% |***********                    |  1597k  0:00:03 ETA
helm-monitor_linux_0 100% |*******************************|  4179k  0:00:00 ETA

Installed plugin: monitor
$ helm monitor
Error: fork/exec /root/.helm/plugins/helm-monitor/helm-monitor: no such file or directory

I try mkdir -p /root/.helm/plugins/helm-monitor/helm-monitor but I get
mkdir: can't create directory '/root/.helm/plugins/helm-monitor/helm-monitor': File exists

The container I try to do the above is based on alpine:latest .

Any help would be appreciated!

Hi Team ,

We are facing issue while using helm monitor plugin. Prometheus server is up and running. But when we are using it with helm monitor commands its not working. We have tried with different PROMQL query as well but still same result.

prometheus server :-
curl http://IP:PORT/-/healthy
Prometheus Server is Healthy.

helm monitor prometheus --prometheus=http://IP:PORT my-release 'rate(http_requests_total{code=~"^5.*$"}[5m]) >
0'
Error: context deadline exceeded
Usage:
monitor prometheus [flags] RELEASE PROMQL

Flags:
-h, --help help for prometheus
--prometheus string prometheus address (default "http://localhost:9090")

Global Flags:
--dry-run simulate a rollback if triggered by query result
--expected-result-count int number of results that are expected to be returned by the query (rollback triggered if the number of results exceeds this value)
--force force resource update through delete/recreate if needed
-i, --interval int time in seconds between each query (default 10)
--no-hooks prevent hooks from running during rollback
--rollback-timeout int time in seconds to wait for any individual Kubernetes operation during the rollback (like Jobs for hooks) (default 300)
--timeout int time in seconds to wait before assuming a monitoring action is successfull (default 300)
-v, --verbose enable verbose output
--wait if set, will wait until all Pods, PVCs, Services, and minimum number of Pods of a Deployment are in a ready state before marking a rollback as successful. It will wait for as long as --rollback-timeout

Error: plugin "monitor" exited with error

We have installed Elasticsearch also and tried with that , getting the same output with Elasticsearch also.

Can this plugin monitor custom sources? e.g. Cloudwatch metrics or similar.

is this support helm3