Comments (3)
Typo resolved in this PR, but issue remains that we need to understand and fix at least testing.
from mir.
In addition to figuring out why the tests passed despite the error, we should write unit tests for the checkpoint, which should have discovered that bug in the first place.
from mir.
Good news. It is what I suspected - the async multisig collector. The system is just too fast to notice the problem with the checkpoint, because everything gets delivered before the checkpoint. When I set the limit of sub-certificates in the multisig collector back to one, the test fails as it should.
from mir.
Related Issues (20)
- Make factory modules automatically tolerate concurrent application events HOT 1
- Separate transport module and logic
- Eliminate unnecessary sender field used in the transport module
- Declare generated code as such
- Write a high-level description of Trantor HOT 1
- IPC M2 Critical Issues HOT 5
- Change membership info to use network protocol as a fallback
- Inefficient slice lookup
- Define constraints on membership weights
- Rename Trantor events to be consistent with protocol description
- Breaking changes in crypto library (G1 curve problem) HOT 1
- Serializing empty slices in protobufs
- Conversion of checkpoints in iss.go HOT 1
- Expose basic notion of wall clock time in Trantor
- Transactions getting lost between multisig collector and ISS HOT 1
- Optimize batch reconstruction in Trantor's availability module
- Epoch-aware orderers
- Remove old ISS terminology from the Trantor implementation
- Use zero `MaxProposeDelay` as a default value for PBFT in Trantor
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mir.