Comments (6)
Sounds reasonable -we can't write any hugely meaningful tests since it's mainly just the API behaviour that changes. A test that uses new implemented arguments is mainly useful to catch regression or developer error so shouldn't be too tricky. Happy to review if you want to have a go.
Semi-related - I refactored the codebase without disrupting the user facing API on this branch. It drops some of the cruft like async.io loops and async funcs that don't really add much, and should hopefully allow progress bars. Feel free to check out https://github.com/connelldave/botocove/tree/progress_bar if you'd like to test. It'll be easy to port contributions to that change too if needs be.
from botocove.
Happy to review if you want to have a go.
Okay, thanks! I hope I can find time this week to implement it.
I refactored ... should hopefully allow progress bars.
Glad to hear it :-) I'll copy the comment to #11.
from botocove.
I started to study the code and the other PR a couple of weeks ago, but didn't have time to commit any changes.
It's still a priority for me! I hope to find enough free time soon.
from botocove.
I submitted a pull request to solve this for the Policy parameter.
Let me know what you think.
When you're happy with it I can extend it to support the PolicyArns parameter too.
from botocove.
Thanks for this Iain - now in 1.4.1 - it'd be great to hear more about your use case for it!
from botocove.
@connelldave I'll update my aws-org-inventory tool soon to use a generic read-only session policy.
In more specialized code I would use a session policy that allows only the AWS API actions required by the function executed by botocove.
Say I need to retrieve the template for every instance of a named stack. I'd pass a function to botocove that calls boto3 method CloudFormation.Client.get_template. I'd also pass a session policy that allows just the cloudformation:GetTemplate
IAM action.
from botocove.
Related Issues (20)
- How to reduce memory usage? HOT 13
- A PyTest-style CLI to run cove-annotated functions HOT 6
- Raises TypeError for some custom exceptions HOT 7
- botocore WaiterError causes TypeError HOT 2
- Add support for multiple regions HOT 4
- Include OrganizationId in each CoveSessionInformation HOT 9
- Can we do without DescribeAccount? HOT 5
- Make the progress bar smoother HOT 2
- Add a progress bar for loading organization accounts HOT 8
- Bump moto to 4.x HOT 2
- Validate regions from a known set HOT 9
- Continue to support Python 3.8 HOT 4
- Why are JoinedTimestamp and JoinedMethod missing from the results? HOT 3
- Support alternative AWS Paritions (e.g. GovCloud `aws-us-gov`) HOT 2
- Run Actions for all contributions
- Add contributor documentation
- Latest CI is slow and fails HOT 4
- Would it be possible to use the decorator session within @cove() annotation to load the regions that are relevant for session account? HOT 12
- Enabled opt-in region gives AuthFailure
- Is botocove compatible with Python 3.11, 3.12? HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from botocove.