Code Monkey home page Code Monkey logo

Comments (6)

connelldave avatar connelldave commented on July 22, 2024

Sounds reasonable -we can't write any hugely meaningful tests since it's mainly just the API behaviour that changes. A test that uses new implemented arguments is mainly useful to catch regression or developer error so shouldn't be too tricky. Happy to review if you want to have a go.

Semi-related - I refactored the codebase without disrupting the user facing API on this branch. It drops some of the cruft like async.io loops and async funcs that don't really add much, and should hopefully allow progress bars. Feel free to check out https://github.com/connelldave/botocove/tree/progress_bar if you'd like to test. It'll be easy to port contributions to that change too if needs be.

from botocove.

iainelder avatar iainelder commented on July 22, 2024

Happy to review if you want to have a go.

Okay, thanks! I hope I can find time this week to implement it.

I refactored ... should hopefully allow progress bars.

Glad to hear it :-) I'll copy the comment to #11.

from botocove.

iainelder avatar iainelder commented on July 22, 2024

I started to study the code and the other PR a couple of weeks ago, but didn't have time to commit any changes.

It's still a priority for me! I hope to find enough free time soon.

from botocove.

iainelder avatar iainelder commented on July 22, 2024

I submitted a pull request to solve this for the Policy parameter.

Let me know what you think.

When you're happy with it I can extend it to support the PolicyArns parameter too.

from botocove.

connelldave avatar connelldave commented on July 22, 2024

Thanks for this Iain - now in 1.4.1 - it'd be great to hear more about your use case for it!

from botocove.

iainelder avatar iainelder commented on July 22, 2024

@connelldave I'll update my aws-org-inventory tool soon to use a generic read-only session policy.

In more specialized code I would use a session policy that allows only the AWS API actions required by the function executed by botocove.

Say I need to retrieve the template for every instance of a named stack. I'd pass a function to botocove that calls boto3 method CloudFormation.Client.get_template. I'd also pass a session policy that allows just the cloudformation:GetTemplate IAM action.

from botocove.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.