Code Monkey home page Code Monkey logo

Comments (18)

xylar avatar xylar commented on September 27, 2024 2

I'm going to go ahead and work on this.

Here's the checklist:

from poetry-feedstock.

xylar avatar xylar commented on September 27, 2024 2

@aryarm, hmm, this is a fair amount of work. Good thing I'm a sucker for the sunken cost fallacy. I've put too much effort in now to abandon this thing... ;-)

from poetry-feedstock.

xylar avatar xylar commented on September 27, 2024 1

I mostly wanted to be sure that you need poetry and not just poetry core. It sounds like the answer is, yes you do. It's not a ton of work. I just dropped it earlier because it turned out I didn't need it myself.

from poetry-feedstock.

xylar avatar xylar commented on September 27, 2024 1

@maresb, that experiment you can already do. You need to install the development version of poetry-core with:

conda install -c conda-forge/label/poetry_dev "poetry-core>1.0.7"

or include this channel in creating your development environment. You don't need the full poetry.

from poetry-feedstock.

xylar avatar xylar commented on September 27, 2024 1

@maresb, I think you're confusing poetry versioning with poetry-core versioning. They're separate things.

from poetry-feedstock.

xylar avatar xylar commented on September 27, 2024 1

In earnest, though, these kinds of projects are always good exercises. I needed a reminder how to make use of multiple dev. packages at once. And virtualenv definitely needs some help, which I wouldn't have noticed without this work.

from poetry-feedstock.

xylar avatar xylar commented on September 27, 2024

@aryarm, for my own work, it turned out that the alpha version of potery-core was sufficient, see:
conda-forge/poetry-core-feedstock#12

I am happy to create a dev branch of poetry, but it relies on development versions of other packages (poetry-core and cleo), so it's substantially more effort than just making a development version of this one package:
https://github.com/python-poetry/poetry/blob/1.2.0a2/pyproject.toml#L34-L35

I just want to make sure it's worth the effort.

from poetry-feedstock.

aryarm avatar aryarm commented on September 27, 2024

Hi @xylar,

On my end, this isn't a super important request. After all, I can always just use the standard install script instead of installing from conda-forge. But it would certainly be nice to be able to isolate my poetry installation in a conda environment. I'm elated that you're taking up the mantle on this, but no need to put too much work into it if it's really difficult.

from poetry-feedstock.

maresb avatar maresb commented on September 27, 2024

I've been very eager to get PEP 660 support which has been sitting in the main branch of poetry-core for what seems like ages.

...hmm, but thinking this through, i think it's only really useful for that purpose if it's on PyPI.

from poetry-feedstock.

xylar avatar xylar commented on September 27, 2024

@maresb, I think that feature will likely still be useful on conda-forge. My guess is that, if you include the alpha version of poetry from conda-forge in your development environment, you'll be able to do python -m pip install -e .. Obviously, we can at least try it out.

from poetry-feedstock.

maresb avatar maresb commented on September 27, 2024

Ah, good point! Yes, it would be very interesting to try out.

To be specific, the experiment is to do an editable install with the following pyproject.toml

[build-system]
requires = ["poetry-core>1.0.7"]
build-backend = "poetry.core.masonry.api"

which should fail without an existing install given that the latest PyPI version is 1.0.7.

from poetry-feedstock.

maresb avatar maresb commented on September 27, 2024

Hmm, I must say that I really don't understand poetry-core's versioning conventions...

The current stable release is 1.0.7 from Oct 4, 2021. There is a prerelease of 1.1.0a6 from July 30, 2021, which is also the latest version with the poetry_dev label. (This prerelease does not support PEP 660.) So the stable release is newer than the alpha series. Then I look on the master branch and there the version is 1.1.0a6.

But @aryarm was referring to a mysterious 1.2. Is this an actual thing?

So I'm not sure what to expect. Is the next release going to be 1.1.0a7, 1.1.0 or 1.2.0?

from poetry-feedstock.

xylar avatar xylar commented on September 27, 2024

And, yes, poetry-core seems to be developing 1.0.x in parallel with 1.1.0ax, and similarly for poetry.

from poetry-feedstock.

aryarm avatar aryarm commented on September 27, 2024

@xylar, you have my glowing admiration! I appreciate you so much :D

I hope you know that your efforts are also pretty inspiring to students like me. I think I'd like to learn how to contribute to feedstocks myself, now. And thanks for outlining things in that checklist - that really helps me keep track and understand what you've been up to

from poetry-feedstock.

xylar avatar xylar commented on September 27, 2024

I hope you know that your efforts are also pretty inspiring to students like me. I think I'd like to learn how to contribute to feedstocks myself, now.

I would be happy to help you get started if you have software of your own you'd like to create a recipe for, or if there's software not yet on conda-forge you'd like to add. poetry isn't exactly the simplest starting point :-)

from poetry-feedstock.

xylar avatar xylar commented on September 27, 2024

@aryarm, this should be available by tomorrow. To install it, you need to include the channels -c conda-forge/label/poetry_dev and -c conda-forge/label/cleo_dev. Something like this:

conda create -y -n dev -c conda-forge/label/poetry_dev -c conda-forge/label/cleo_dev -c conda-forge python=3.10 poetry=1.2.0a2 <other_packages>

Let me know how that goes.

from poetry-feedstock.

xylar avatar xylar commented on September 27, 2024

Closed via #58

from poetry-feedstock.

maresb avatar maresb commented on September 27, 2024

Thank you very much @xylar! Because of this build I'm now able to use the CLI flags from Poetry v1.2 within my Conda environments. I really appreciate your work on this.

from poetry-feedstock.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.