Comments (7)
Abseil is a non-trivial dependency with less than ideal versioning where I'd be -1 on making that the default build.
As of #48, opentelemetry will depend on abseil (through protobuf 4.x), so this point is moot. Not sure if we gain anything by flipping WITH_ABSEIL
though? CC @lidavidm
from cpp-opentelemetry-sdk-feedstock.
Looks like abseil usage is only if you're not using STL: https://github.com/open-telemetry/opentelemetry-cpp/blob/v1.6.0/api/include/opentelemetry/nostd/variant.h
So really this is just if we should use the STL or not.
from cpp-opentelemetry-sdk-feedstock.
We can probably build with abseil and get two bird with one stone (since on C++17, abseil will already mostly use STL for its types).
from cpp-opentelemetry-sdk-feedstock.
We can probably build with abseil and get two bird with one stone (since on C++17, abseil will already mostly use STL for its types).
Abseil is a non-trivial dependency with less than ideal versioning where I'd be -1 on making that the default build.
from cpp-opentelemetry-sdk-feedstock.
Meh, it's already everywhere (including now protobuf's API). 🤷
Especially as I expect most users of this lib to come through arrow, which already depends on abseil.
from cpp-opentelemetry-sdk-feedstock.
Yeah, and additionally they've said upstream that C++17 support effectively requires WITH_STL.
From a quick search, the flag still configures whether it tries to link some abseil libraries into OTel. But it's overridden in the source itself via ifdefs, so I say it's a pointless flag and we just use WITH_STL.
(Also, if you don't use WITH_STL and don't use WITH_ABSEIL, it just pulls a vendored copy anyways. 🤦)
from cpp-opentelemetry-sdk-feedstock.
Yeah, and additionally they've said upstream that C++17 support effectively requires WITH_STL.
Well, that's because at C++17, abseil effectively delegates everything to the stdlib. So I think I'll stay with abseil for now, because it should have a superset of capabilities than what the stdlib offers (happy to be corrected though if I'm wrong on this).
(Also, if you don't use WITH_STL and don't use WITH_ABSEIL, it just pulls a vendored copy anyways. 🤦)
Yeah, I noticed, which is why we're getting symbol collisions now that abseil is on the library path. We have to bite the bullet anyways.
from cpp-opentelemetry-sdk-feedstock.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cpp-opentelemetry-sdk-feedstock.