Comments (5)
Both are fine, except when you have [...]
What's the benefit of allowing the build:
-less way, except saving some characters? I don't think that's worth the footgun that comes along with it.
I mean, if we can lint the specific case that breaks, all the better, but I'd be equally happy to just require a build:
section.
from conda-smithy.
The correct placement would be
outputs:
- name: blah
build:
run_exports:
- blah
from conda-smithy.
What's the benefit of allowing the build:-less way, except saving some characters? I don't think that's worth the footgun that comes along with it.
You'll shoot yourself in the foot if you only move run_exports
to build
and the other values are not moved to the build
section.
from conda-smithy.
Both are fine, except when you have
outputs:
- name: blah
run_exports:
- blah
build:
some_other_option: value
from conda-smithy.
Right. My proposal is to require only stuff under build in conda-forge to make things simpler and less error prone. We could lint exactly for the bug if we want OFC.
from conda-smithy.
Related Issues (20)
- Missing auxlib.packaging
- add default branches that are ignore by smithy for uploads HOT 2
- Flawed conda-forge-only meta.yaml lint #1 (already-exists lint): Multiple PyPI sources
- Unable to install conda-smithy using the conda install command (gets killed) HOT 1
- ENH: Warn on non-existent `abi_migration_branches`
- BUG: smithy ignores keys in migrator when affected by zipping logic HOT 2
- Release 3.35.0 HOT 8
- BUG: something non-deterministic going wrong in squished_input_variants/preserve_top_level_loops HOT 4
- Linter hint about `{{ stdlib("c") }}` variable is incorrect for noarch packages HOT 1
- conda-smithy rendered circle ci config for feedstocks don't run HOT 1
- BUG: MACOSX_SDK_VERSION not participating in merge logic HOT 7
- lint on most wheel-based python installs except `noarch: python` and `none-any.whl` HOT 3
- How to test updates to `.travis.yml` HOT 3
- ENH: extend free_disk_space to windows? HOT 1
- c_stdlib_version in conda_build_config.yaml ignored when cuda is used
- Additional rust linter rules
- rerender inverts a github_actions option in conda-forge.yml
- Refactor `anaconda_token_rotation.rotate_anaconda_token` HOT 6
- Why do we use ruamel.yaml next to PyYAML? HOT 1
- Allow customizations of shellcheck linter
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from conda-smithy.