Comments (5)
It could definitely be done in a technically cleaner way, but at present setting cell metadata is not a very nice UI (it brings up a dialog where you can modify JSON by hand).
from nbval.
Being able to use the cell metadata is a nice option where we don't want to show the fact that a cell is excluded from testing, for example in notebooks that serve as polished documentation aiming at beginners. At other times, it might be useful to be explicit that a particular cell is not tested. So it would be good to have both options, i.e. the existing (#PYTEST_VALIDATE_IGNORE_OUTPUT) in the input cell, and the ability to achieve the same via metadata.
from nbval.
This would combine well with a custom nbval cell toolbar (e.g. with some checkboxes for flags).
from nbval.
With basic tags UI now in notebook master (jupyter/notebook#2048), I think this discussion can be revived with tags in mind. If we use tags for nbval, should we simply look for tags equal to the current comment strings? And if both a comment and a tag is found, which should take precedence? Etc. etc.
from nbval.
I think the same basic names, but I would make the convention lowercase with dashes, like nbval-check-output
, rather than the capitalised comments like # NBVAL_CHECK_OUTPUT
. I don't have a good reason, that just feels more natural for tags to me.
Not currently sure how precedence and combining them should work. It's already ambiguous what happens if you combine the check and ignore comments in one cell.
from nbval.
Related Issues (20)
- Documentation about skipping certain output types do not work
- Pytest fails to run on a seemingly innocent unit test
- Cell numbers are off by 1 compared to what you see in the notebook
- New release please HOT 2
- Testing structural similarity rather than string identity HOT 2
- When using Sanitizer, Special Chars on notebook are not escaped
- new pytest version throws deprecation warning HOT 3
- 0.9.6: sphinx warnings
- 0.9.6: pytest is failing in few units HOT 3
- CI tests are failing HOT 1
- Many tests fail on FreeBSD HOT 1
- New release? HOT 1
- 0.10.0 release captures output even when ';' is present HOT 3
- javascript not supported? HOT 2
- 0.10.0: documentation build fails
- pytest 8.1.0 breaks nbval 0.10.0 HOT 1
- `--sanitize-with` option seems to be behaving weirdly with "newly computed (test) output"
- Parallel --dist loadscope issue HOT 1
- Sanitize replace regex HOT 2
- Testing differences across two pre-run notebooks / paths
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nbval.