Code Monkey home page Code Monkey logo

Comments (15)

LilyAndres avatar LilyAndres commented on June 12, 2024 3

Thanks for your comment @laurenechan. We have discussed this matter and we think maybe replacing the label of the 'dietary nutritional component' class with 'dietary chemical component' could work? As @maweber-bia mentioned, we need to think about how to define chemical components that are not necessary nutrients but are still in the diet. We presented a Venn diagram of these categories in one of the IFOW monthly meetings in Sept 2021.

image
In this case, the minerals that are ingested in the diet but that are not nutrients could be classified in a separate subclass, for example ‘mineral non-nutrient’. I’m not sure whether we yet have the ideal label but this is the idea. Here is an example of the hierarchical classifications:

image

What do you think?

from cdno.

maweber-bia avatar maweber-bia commented on June 12, 2024 2

As previously discussed (see issues #65, #30) a "dietary component" can have either a "nutritional" or a "non-nutritional" role

This should be clear in the hierarchy of components as well :

"dietary" indicates that the component is provided by food (in a diet) but we should have dietary nutritional components and dietary non-nutritional components (those components which have a biological role - either positive effect or negative effect- but which are not nutrients)

from cdno.

ddooley avatar ddooley commented on June 12, 2024 1

Looks good to me - your classes like "dietary calcium" reflect the amount of information available from existing datasets. The subclasses can be referenced if more specific calcium form testing data is available.

from cdno.

maweber-bia avatar maweber-bia commented on June 12, 2024 1

I fully agree with the proposals, well done!

from cdno.

LuciaSegovia avatar LuciaSegovia commented on June 12, 2024 1

Brilliant!! I really like it :) Just one suggestion, for iron, you may want to include haem and non-haem into the hierachy.

from cdno.

laurenechan avatar laurenechan commented on June 12, 2024 1

My apologies if we have already discussed this, but I am slightly concerned with categories like 'dietary lead' or 'dietary arsenic' being subclasses of 'mineral nutrient' given that lead and arsenic are not nutrients. Similar concerns arise for any elements that may be consumed in the diet but do not have actual 'nutrient' capacities for humans. Do we have options for ways to include these dietary components with a different parent class?

from cdno.

LilyAndres avatar LilyAndres commented on June 12, 2024

@ddooley, @CropStoreDb, @kaiiam, @laurenechan, @LuciaSegovia, @maweber-bia, @mateolan, what do you think?

from cdno.

LilyAndres avatar LilyAndres commented on June 12, 2024

Great thank you all :) @LuciaSegovia thanks, I will take that into account, I might need your help to check the hierarchical classification at some point, we will be in touch.

from cdno.

LuciaSegovia avatar LuciaSegovia commented on June 12, 2024

Sure! No problem :)

from cdno.

LilyAndres avatar LilyAndres commented on June 12, 2024

Hello, we have completed a framework proposal for the 'mineral nutrients', please follow the link and feel free to make any comments in column "N", your feedback is much appreciate it :)
@maweber-bia, @LuciaSegovia, @ddooley

from cdno.

kaiiam avatar kaiiam commented on June 12, 2024

Looks good @LilyAndres (from a quick glance I didn't study it all in depth). I'd make sure to add a column of the CHEBI iri's or CURIE's so this can get turned into a robot template.

from cdno.

maweber-bia avatar maweber-bia commented on June 12, 2024

Nice job! just wondering why you did not include "dietary" in the label of silicon dioxide

What will you do with the scientific publications referenced in the spreadsheet? Actually, it is good to know such references

from cdno.

kaiiam avatar kaiiam commented on June 12, 2024

We can (and I think should) add the publication links as cross-references to the terms.

from cdno.

kaiiam avatar kaiiam commented on June 12, 2024

Good points @laurenechan. We should be really clear about what is meant by mineral and nutrient and based on is definition make sure we don't subsume anything under it that should be.

Like Lauren suggests we should have a different parent, something high-level and perhaps from CHEBI for chemicals that we import from CHEBE and present but don't want to call 'nutrients'

from cdno.

LilyAndres avatar LilyAndres commented on June 12, 2024

This issue has been solved in the 3.1 release. I will close it now.

from cdno.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.