Add details to README.md about cdno HOT 20 CLOSED

Hey @kaiiam sounds good, I will try the protocol and let you know how it goes. Thanks for the help!

from cdno.

We don't HAVE to do things this way but it's highly recommended as a best/better practice, (based on the GO experience). So if we build good habits now we'll be better off in the long run, especially if this project lasts a while.

from cdno.

@LilyAndres let me know when you have this info prepared (no rush) and I can teach you how to use a modified version of the GO daily workflow so that you can do it via a branch and pull request. We don't have to do things that way but it's highly recommended as a better practice.

from cdno.

Hi @kaiiam thanks for this, yesterday I wanted to incorporate that information but I thought could be better to do it on the branch which I forgot how to do it, I have done it before, last year I think but if you can help me, would be great. I think I can have everything ready at the end of the day, but let me know which day would be better for you.

from cdno.

@maumauleon sorry I didn't include you earlier, we will add more info ASAP.

from cdno.

@LilyAndres I've written a similar envo-editors-daily-work-flow protocol for ENVO. You can basically just sub out ENVO for CDNO in that protocol.

The main ideas is to do things in a branch instead of on the main development branch, you do with with a command like: git checkout -b issue-x where x corresponds to an issue on the tracker. Then when you push to that branch and go to the github page it'll let you create a pull request.

I've been wanting someone to give my directions a try. It'd be great if you wouldn't mind trying it based on those instructions (with CNDNO instead of ENVO) and let me know how it goes, if anything was unclear etc.

You could do it with just the changes you want to add to the readme file and you can use this issue #3 to make a branch with.

Thanks!

from cdno.

No worries, I definitely need to boost my "skills" on the command line.

from cdno.

The alternative being to directly make commits to master without creating a branch and a pull request, the danger in that is if multiple editors are doing it it can more easily lead to merge conflicts, whereas when we use branches/pull requests we can check and fix merge conflicts more easily. The other issue we've run into in ENVO is spurious diff files when people don't use the latest version of Protege. So once you start making edits to the ontology itself make sure you're using the latest version of Protege.

from cdno.

@LilyAndres I noticed there's a funky non displaying character in the readme.md can you fix it?

from cdno.

Hey thanks @kaiiam, I actually changed the README to incorporate the Scope of the CDNO and I did it through the a branch following the steps in https://github.com/EnvironmentOntology/envo/wiki/Adding-classes-to-ENVO#envo-editors-daily-work-flow, let me know if it's ok please

from cdno.

@LilyAndres the above link doesn't lead anywhere, I was just saying to get rid of that non displaying character in the file https://github.com/Southern-Cross-Plant-Science/cdno/blob/master/README.md.

from cdno.

Oh I see the link is just not displaying on wiki when you click but its to the page I wrote, yes try to do it that way. Currently it's not showing up as a pull request once you run git push it'll show up on the github repo as a pull request.

from cdno.

from cdno.

@LilyAndres are you trying to make a PR to ENVO or to CDNO? Remember that the https://github.com/EnvironmentOntology/envo/wiki/Adding-classes-to-ENVO#envo-editors-daily-work-flow protocol is configured to add to ENVO, so if you're using it for CDNO you'll have to modify it slightly. Make sure the issue corresponds etc, and check the CDNO page, although I don't see any PRs there. Maybe you can sent some screen shots of what happens when your run git status

from cdno.

@LilyAndres it looks like you took care of this in bfdca68 ? if so and or if you're happy with the README then go ahead and close this.

from cdno.

Although maybe not because this section is not accurate since were not just using the edit file. We should maybe update this. @LilyAndres You'll have to explain it for your thesis anyway so you can just add some of what you wrote to the readme.

Editors' version

Editors of this ontology should use the edit version, src/ontology/cdno-edit.owl

from cdno.

Thanks @kaiiam, I used a template to describe the README, so some of the information there is not accurate. I will update this once I have the first release...

from cdno.

from cdno.

@LilyAndres did you took care of this? I though you had if so this is good to close.

from cdno.

Complete it with the new changes for Compositional DNO.

from cdno.